From owner-cvs-src-old@FreeBSD.ORG Thu Oct 1 18:37:35 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F1261065692 for ; Thu, 1 Oct 2009 18:37:35 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7C39E8FC1B for ; Thu, 1 Oct 2009 18:37:35 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n91IbZgI052801 for ; Thu, 1 Oct 2009 18:37:35 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n91IbZ85052800 for cvs-src-old@freebsd.org; Thu, 1 Oct 2009 18:37:35 GMT (envelope-from thompsa@repoman.freebsd.org) Message-Id: <200910011837.n91IbZ85052800@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to thompsa@repoman.freebsd.org using -f From: Andrew Thompson Date: Thu, 1 Oct 2009 18:37:16 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb/controller ehci.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2009 18:37:35 -0000 thompsa 2009-10-01 18:37:16 UTC FreeBSD src repository Modified files: sys/dev/usb/controller ehci.c Log: SVN rev 197682 on 2009-10-01 18:37:16Z by thompsa EHCI Hardware BUG workaround The EHCI HW can use the qtd_next field instead of qtd_altnext when a short packet is received. This contradicts what is stated in the EHCI datasheet. Also the total-bytes field in the status field of the following TD gets corrupted upon reception of a short packet! We work this around in software by not queueing more than one job/TD at a time of up to 16Kbytes! The bug has been seen on multiple INTEL based EHCI chips. Other vendors have not been tested yet. - Applications using /dev/usb/X.Y.Z, where Z is non-zero are affected, but not applications using LibUSB v0.1, v1.2 and v2.0. - Mass Storage (umass) is affected. Submitted by: Hans Petter Selasky MFC after: 3 days Revision Changes Path 1.28 +57 -21 src/sys/dev/usb/controller/ehci.c