From owner-cvs-sbin  Sat Apr 13 11:51:36 1996
Return-Path: owner-cvs-sbin
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id LAA16002
          for cvs-sbin-outgoing; Sat, 13 Apr 1996 11:51:36 -0700 (PDT)
Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id LAA15892
          Sat, 13 Apr 1996 11:50:57 -0700 (PDT)
Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id UAA02579; Sat, 13 Apr 1996 20:50:52 +0200
Received: by sax.sax.de (8.6.11/8.6.12-s1) with UUCP
	id UAA19447; Sat, 13 Apr 1996 20:50:52 +0200
Received: (from j@localhost) by uriah.heep.sax.de (8.7.5/8.6.9) id UAA21438; Sat, 13 Apr 1996 20:31:38 +0200 (MET DST)
From: J Wunsch <j@uriah.heep.sax.de>
Message-Id: <199604131831.UAA21438@uriah.heep.sax.de>
Subject: Re: cvs commit: src/sbin/nfsd nfsd.c
To: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-sbin@freefall.freebsd.org
Date: Sat, 13 Apr 1996 20:31:38 +0200 (MET DST)
Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch)
In-Reply-To: <199604131814.EAA14571@godzilla.zeta.org.au> from "Bruce Evans" at Apr 14, 96 04:14:11 am
X-Phone: +49-351-2012 669
X-Mailer: ELM [version 2.4 PL24 ME8a]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

As Bruce Evans wrote:
> 
> >>      Unless otherwise specified, four servers for UDP transport are started.
> 
> I think this says that 4 servers for UDP transport are started _if UDP
> service is enabled_.

Ah, what sense does it make to start a daemon just with the intention
to do nothing?  (No args -> do nothing.)

Of course, the English language is perhaps more ambigous than C. :-)

> Now UDP is always enabled unless nfsd is execed in an unusual way to
> get argc == 0.
> 
> Bruce
> 
> *** nfsd.c~	Sat Apr 13 20:31:54 1996
> --- nfsd.c	Sat Apr 13 20:37:20 1996
> ***************
> *** 195,198 ****
> --- 195,200 ----
>   #define	USAGE	"[-rtu] [-n num_servers]"
>   #endif
> + 	if (argc <= 1)
> + 		udpflag = 1;
>   	while ((ch = getopt(argc, argv, GETOPT)) != EOF)
>   		switch (ch) {
> ***************
> *** 230,234 ****
>   			usage();
>   		};
> - 	if(argc) udpflag = 1;
>   	argv += optind;
>   	argc -= optind;
> --- 232,235 ----
> 

Ain't this reverse?  (But i agree that it needs to be fixed.)

-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)