Date: Thu, 15 Mar 2018 17:08:07 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: mmel@freebsd.org, Luca Pizzamiglio <pizzamig@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r464493 - in head/devel/gdb: . files files/kgdb Message-ID: <4c7fbdcb-92cb-bac5-0744-e0ab1677a63f@FreeBSD.org> In-Reply-To: <8b7bf792-71e8-c636-82f7-db0fbc5827b0@FreeBSD.org> References: <201803141433.w2EEXMGn079353@repo.freebsd.org> <3f23cada-14ff-d959-3445-7f4f0043ebf6@freebsd.org> <8b7bf792-71e8-c636-82f7-db0fbc5827b0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Nh8nttfeotMXrxfImF0l3WcWaqv93pXZ Content-Type: multipart/mixed; boundary="93THk9QB4QtI1U1ODfy3knazW0x214Mxb"; protected-headers="v1" From: Jung-uk Kim <jkim@FreeBSD.org> To: mmel@freebsd.org, Luca Pizzamiglio <pizzamig@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <4c7fbdcb-92cb-bac5-0744-e0ab1677a63f@FreeBSD.org> Subject: Re: svn commit: r464493 - in head/devel/gdb: . files files/kgdb References: <201803141433.w2EEXMGn079353@repo.freebsd.org> <3f23cada-14ff-d959-3445-7f4f0043ebf6@freebsd.org> <8b7bf792-71e8-c636-82f7-db0fbc5827b0@FreeBSD.org> In-Reply-To: <8b7bf792-71e8-c636-82f7-db0fbc5827b0@FreeBSD.org> --93THk9QB4QtI1U1ODfy3knazW0x214Mxb Content-Type: multipart/mixed; boundary="------------67F95C908E5764DB7ECA063E" Content-Language: en-US This is a multi-part message in MIME format. --------------67F95C908E5764DB7ECA063E Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/15/2018 15:19, Jung-uk Kim wrote: > On 03/15/2018 10:26, Michal Meloun wrote: >> >> >> On 14.03.2018 15:33, Luca Pizzamiglio wrote: >>> Author: pizzamig >>> Date: Wed Mar 14 14:33:21 2018 >>> New Revision: 464493 >>> URL: https://svnweb.freebsd.org/changeset/ports/464493 >>> >>> Log: >>> =C2=A0=C2=A0 devel/gdb: Update to version 8.1 >>> =C2=A0=C2=A0 =C2=A0=C2=A0 The official annoucement is available here:= >>> =C2=A0=C2=A0 https://www.gnu.org/software/gdb/download/ANNOUNCEMENT >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Moreover: >>> =C2=A0=C2=A0 * support for 'info proc' is added (jhb@) >>> =C2=A0=C2=A0 * update kgdb to use gdb 8.1 >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Reviewed by:=C2=A0=C2=A0=C2=A0 jhb@ >>> =C2=A0=C2=A0 Differential Revision:=C2=A0=C2=A0=C2=A0 https://reviews= =2Efreebsd.org/D14148 >>> >> This caused breakage for (at least) amd64, armv6, armv7, arm64 on >> 12/head. On all these arches, compile fails with: >> (taken from amd64 build) >> >> arch/arm-get-next-pcs.c:52:26: error: constant expression evaluates to= >> -1 which cannot be narrowed >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 to type 'CORE_ADDR' (aka 'unsigned long= ') [-Wc++11-narrowing] >> =C2=A0 CORE_ADDR breaks[2] =3D {-1, -1}; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = ^~ >> arch/arm-get-next-pcs.c:52:26: note: insert an explicit cast to silenc= e >> this issue >> =C2=A0 CORE_ADDR breaks[2] =3D {-1, -1}; > ... >=20 > The attached patch worked around the problem for me. While we are at it, we should remove "-Wno-extended-offsetof" from CFLAGS. It was deprecated in Clang 6. https://llvm.org/viewvc/llvm-project?view=3Drevision&revision=3D318796 Jung-uk Kim --------------67F95C908E5764DB7ECA063E Content-Type: text/x-patch; name="gdb.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="gdb.diff" Index: devel/gdb/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- devel/gdb/Makefile (revision 464633) +++ devel/gdb/Makefile (working copy) @@ -90,8 +90,12 @@ CONFIGURE_TARGET=3D x86_64-portbld-freebsd${OSREL} .endif =20 .if ${COMPILER_TYPE} =3D=3D "clang" +.if ${COMPILER_VERSION} < 60 CFLAGS+=3D -Wno-extended-offsetof +.else +CXXFLAGS+=3D -Wno-c++11-narrowing .endif +.endif =20 post-patch: @${REINPLACE_CMD} -e 's|$$| [GDB v${PORTVERSION} for FreeBSD]|' \ --------------67F95C908E5764DB7ECA063E-- --93THk9QB4QtI1U1ODfy3knazW0x214Mxb-- --2Nh8nttfeotMXrxfImF0l3WcWaqv93pXZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlqq4LcACgkQfJ+WJvzb 8UYN7Qf8CTPOVxk7EnqimlEACJre0IMmZ1lon5coURpYUtvsf6aDrDs5lo4m+1MD F/Bfo1OU6KpYJeFQcO2At0VeT+cukyBM8LvimCZ0Xg2S5g0I/fdKTnVuTwwAdDxU FBOLb5Ftv2pnJWVsVWjBOhTHelR7/98JqvR3m0J3RBWMrsmX3LWG487HK+nal6BM FPNbwC10zCKMrPgSdP4HQIGwC1v6nQvmkekOez2CCYMJmvqQbIolJlWYkB8TcUr2 6Kc+U/dRgngXMioBNFhRX9djfGkyuv+iMBgHtWh86+tHz42tJ2vLiOP/qav5OEEb 5XfF2se2gGu2jJdPyZG5+T9/i7s4WQ== =AacQ -----END PGP SIGNATURE----- --2Nh8nttfeotMXrxfImF0l3WcWaqv93pXZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4c7fbdcb-92cb-bac5-0744-e0ab1677a63f>