From nobody Sat Oct 11 12:03:58 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ckMht6q7Wz6Blh7; Sat, 11 Oct 2025 12:03:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ckMht46mtz3rJB; Sat, 11 Oct 2025 12:03:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760184238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6dwNF/wdwLtLXS2408iyOO3nZH0j4OfXctcggcv0eA0=; b=F/Z9HChgqP5OYhM95mpx5MCsU+erSb5RKF3ApVitT90vqa4widOYKvdje7NO+2L931HVTc m+BD9aUoW8lTo0Ndt3ZTBtlsiDDRxKxWZ+TYKWnAyeTbUt2EnaeVMfuZ9IPFgyxa89gOse K97TzovyH9CLfZHbshLAGbsBDoFqYZfuL7vGXLKnizrxrr9dDo5nQ80IetdJe0PJUEAfI+ tjQckhFRTxJxAN6PBICxba/WWC5Nv54/6PkFERSDxp8C1rhy8u6v2y37pJEkb2AUT3u9XQ GRA9b4X9cMdci4n1doQ5aA7yNThbLmA71bfzVWwIMylU4TXd5JIzaRyzcMNafw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760184238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6dwNF/wdwLtLXS2408iyOO3nZH0j4OfXctcggcv0eA0=; b=Q9CU9KIrYM9H0SpiPiKI2yWylgGX5JzZ/+cVlSICvgY/H7qTmTkEkYAGb+7srj7UDVNneR JPQOGl+k6WLCl0DKiv2jTskcdi7heg87xumQ1jJ70jqKp5UdF87PU1eFn+YGLVpbMWEgMa d4lhIfbBdwv9V+I22klPCgWUaVzclrDjgfJCNURcSKFMrX2bCqN6TDhcevGcodcwo0mIHr jRVJHvSFx7M4ThHzd4Scfz7xT0qyxWH2luaMQBFEB/W28UBqvGVTduBrlnzawkdHmxKdcl 8roflmY28jvkl3FzDhleKFUJ4q3kvTq5dgBKd5LuWROtxTKGdeCeIp+ubAYetQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760184238; a=rsa-sha256; cv=none; b=BG/8+SB6dhj5HEy3MU+q4PGrb/DieEJD6YUJq5LkZsLUl0o7bus1VK8W2HQOSmKdlMpLdd Hnz2IU1mzwhKSJLZdlj+mpSBGIiBMjtoKxixsNVFoKhXdukizSPmULPIC38tZGMX83mf92 pkmNWFOM1p6GAtuX44owkl4+aOiB+oEZk4qRsKEEtdwrfSgo+VX4gRYmGW2qdBZCAhA9H+ b7ilgBkvPlQ0IoB42U6vP5twzwJl5GTMnRXVAA5miSRcPQe+P6SPeJJ8FXtqmjoS78Jb9E fRIh31Ac8rQgmepJ0gUl106aa4O++q+8fmPVIUPdnQgE0Yk6aNpRxQmtBio3sA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ckMht3WQYzYkx; Sat, 11 Oct 2025 12:03:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59BC3w87040118; Sat, 11 Oct 2025 12:03:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59BC3wbK040115; Sat, 11 Oct 2025 12:03:58 GMT (envelope-from git) Date: Sat, 11 Oct 2025 12:03:58 GMT Message-Id: <202510111203.59BC3wbK040115@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 1735d66a9c5b - main - pf tests: verify checksum offload handling List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1735d66a9c5b08b59a0323d3825d2e7dacd13064 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=1735d66a9c5b08b59a0323d3825d2e7dacd13064 commit 1735d66a9c5b08b59a0323d3825d2e7dacd13064 Author: Kristof Provost AuthorDate: 2025-10-10 15:43:28 +0000 Commit: Kristof Provost CommitDate: 2025-10-11 11:24:25 +0000 pf tests: verify checksum offload handling Disable epair's checksum offload on one interface in a nat test, to ensure that pf does the right thing in scenarios where one interface offloads checksum handling and one does not. We trust the TCP (or ICMP) checksum verification code to drop the packet if pf does it wrong, which will cause the test case to fail. Suggested by: tuexen Sponsored by: Rubicon Communications, LLC ("Netgate") --- tests/sys/netpfil/pf/nat.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/sys/netpfil/pf/nat.sh b/tests/sys/netpfil/pf/nat.sh index 63658164c1fe..1ef87cee3598 100644 --- a/tests/sys/netpfil/pf/nat.sh +++ b/tests/sys/netpfil/pf/nat.sh @@ -55,6 +55,9 @@ exhaust_body() jexec echo ifconfig ${epair_echo}b 198.51.100.2/24 up jexec echo /usr/sbin/inetd -p ${PWD}/inetd-echo.pid $(atf_get_srcdir)/echo_inetd.conf + # Disable checksum offload on one of the interfaces to ensure pf handles that + jexec nat ifconfig ${epair_nat}a -txcsum + # Enable pf! jexec nat pfctl -e pft_set_rules nat \