From owner-freebsd-current@FreeBSD.ORG Mon Sep 24 14:59:18 2007 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2ED2F16A417 for ; Mon, 24 Sep 2007 14:59:18 +0000 (UTC) (envelope-from dlt@mebtel.net) Received: from bilbo.mebtel.net (mail3.mebtel.net [64.40.67.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1196E13C448 for ; Mon, 24 Sep 2007 14:59:17 +0000 (UTC) (envelope-from dlt@mebtel.net) Received: from localhost (localhost [127.0.0.1]) by bilbo.mebtel.net (Postfix) with ESMTP id E62857B62; Mon, 24 Sep 2007 10:17:11 -0400 (EDT) Received: from bilbo.mebtel.net ([127.0.0.1]) by localhost (mail3 [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 16860-02-4; Mon, 24 Sep 2007 10:17:10 -0400 (EDT) Received: from localhost (66-79-79-161.dsl.mebtel.net [66.79.79.161]) by bilbo.mebtel.net (Postfix) with ESMTP id 25AB97B64; Mon, 24 Sep 2007 10:17:10 -0400 (EDT) Date: Mon, 24 Sep 2007 10:17:10 -0400 From: Derek Tattersall To: Eygene Ryabinkin Message-ID: <20070924141710.GA80377@lorne.arm.org> References: <20070924093837.GE8111@void.codelabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070924093837.GE8111@void.codelabs.ru> User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Virus-Scanned: by amavisd-new at mebtel.net Cc: current@FreeBSD.org Subject: Re: [RFC] Make /bin/sh's case construct POSIX-2 conformant X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dlt@mebtel.net List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2007 14:59:18 -0000 * Eygene Ryabinkin [070924 08:57]: > Good day. > > Basically all that I will say here (and more) is said in bin/116559, > http://www.freebsd.org/cgi/query-pr.cgi?pr=116559 > > IEEE 1003.2 specifies that the return value of the 'case' construct > that did not matched any patterns shall be zero. It is not the > case now, as shown by the simple test: > ----- > #!/bin/sh > > false > case test in > Test) > ;; > esac && echo ok > ----- > Now the case that has no patterns matched does not touch the exit > value at all. PR has the patch that fixes the issue. > > Any comments on it? Maybe someone will be so kind to test this > patch on his system(s)? Mine are showing no troubles yet ;)) > > Thank you! > -- > Eygene > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" On my amd64 -CURRENT system, cvsuped yesterday, the patch applies cleanly, the build of sh proceeded without error and the test worked perfectly. Thanks very much for the improvement! -- Best regards, Derek Tattersall dlt@mebtel.net dlt666@yahoo.com dtatters@gmail.com