From owner-freebsd-current@FreeBSD.ORG Wed Aug 11 15:21:07 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3574B1065670 for ; Wed, 11 Aug 2010 15:21:07 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id D62FC8FC08 for ; Wed, 11 Aug 2010 15:21:06 +0000 (UTC) Received: by vws7 with SMTP id 7so175664vws.13 for ; Wed, 11 Aug 2010 08:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=yA5hVrTJJDy4H3n6ks5qdKRTn3hfRyghmJ68Mytv4zo=; b=LR1LHDr8n9cm0soAzNyv1vrzsnWok4dYaN2sfzsSPaJznoElixWF1RyctjAteuScrH Z09A/gQ+9U9jLTuk/Qeilw4mekzinxtsDZVIrYa/TuYoQWdU59Y5jJUUVKpr/vGCNi7J u+Hvh/SFKhBHtOyd7DVSj99bkapv2QBjuKjow= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=YRlMfN9nhSZEA8Y32F7DqRldJc68Wz9tAPLY1Fzs2L59hxAu0gMZJfVAkAVj6zXiX7 w8Jdj9p91Y76p6SU6sXQAPIdrlIUAQ7a7MvPmm+G8vc8L059mwfKf8JN3t3SoxoDcDRn NAUBBr/Dl3G2ZOilB0duDdPaspRn6jkPMkuVA= Received: by 10.220.60.204 with SMTP id q12mr11678776vch.41.1281540063893; Wed, 11 Aug 2010 08:21:03 -0700 (PDT) Received: from localhost ([188.72.225.172]) by mx.google.com with ESMTPS id m4sm132908vbp.6.2010.08.11.08.21.00 (version=SSLv3 cipher=RC4-MD5); Wed, 11 Aug 2010 08:21:02 -0700 (PDT) From: Anonymous To: jhell References: <4C61C50E.8040900__28807.0786548362$1281476071$gmane$org@dataix.net> <86sk2lxrvr.fsf@gmail.com> <4C62B237.7070501@dataix.net> Date: Wed, 11 Aug 2010 19:16:00 +0400 In-Reply-To: <4C62B237.7070501@dataix.net> (jhell@dataix.net's message of "Wed, 11 Aug 2010 10:22:47 -0400") Message-ID: <86d3tpuqmn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-current@FreeBSD.org Subject: Re: [CFT] [sys/conf/newvers.sh] Cleanup and additions. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2010 15:21:07 -0000 jhell writes: > On 08/11/2010 08:20, Anonymous wrote: >> jhell writes: >> >>> Based on the parts of the script with the additions for tracking source >>> using git(1) I set out to add support for mercurial hg(1) and ended up >>> cleaning some of the script while making some of those additions. >> >> FYI, some ports don't like unusual characters in uname(1), e.g. ports/148255. > > Thank you for the heads-up. > > I can adjust for that. This was original git code from newvers.sh that I > had let be what it is now and really holds no extra meaning to me unless > it does to someone else?. > > Easy enough to change 137,13 to a space instead of equal sign. > > Questionable whether the '+' sign at 143,14 would cause any problems so > I am testing that out now and will submit another followup patch. No, `=' and `+' signs are good enough. It's just when introducing[1] such changes better to do an exp-run on ports tree so you can identify all ports that try to do funny things with the tool's output and fix them. Besides, as noted in gentoo bug it affects hostname, too. [1] and you're not the one who introduced `=' sign > > Does not make any sense to me why a port would configure using (uname > -v) for identifying its environment. More specifically there should not > be anything more needed than the output of ( uname -rms ) and maybe on > occasion '-n' and __FreeBSD_version. Since I can't trace back in perl5 repo why `=' is stripped my guess it's some kind of ancient workaround myuname=`echo $myuname | $sed -e 's/^[^=]*=//' -e "s,['/],,g" | \ ./tr '[A-Z]' '[a-z]' | $tr $trnl ' '` > > I have had thoughts before about a patch for uname that also outputs the > ABI or __FreeBSD_version but really don't see a need for that since it > can already be identified by kernel headers or through the use of > sysctl(8) or some system call. Nah, __FreeBSD_version is not atomic. Would be better if there was at least svn revision exported via sysctl separate from kern.version.