From owner-svn-src-head@freebsd.org Sat Jun 16 19:21:48 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C91ED101FC17; Sat, 16 Jun 2018 19:21:47 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f50.google.com (mail-it0-f50.google.com [209.85.214.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D2916C690; Sat, 16 Jun 2018 19:21:47 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f50.google.com with SMTP id 16-v6so7031003itl.5; Sat, 16 Jun 2018 12:21:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=Xclq+WcddKhvAiDjEWCqJj5JZ+/rPx+3sIzxIUmFbfQ=; b=DaiPJMAO4w/TyFKCfAFaMsuCX+upd3x4MzmVdyD4414CuGNP/cyWmcGC5G+jn7UyF5 JAM/0661YBupu9VF+IVusGv1W6xOxbqUr9NqnhNjML7/1+DDdyjJ66L2bvE9yO9ib0Od QFsYD7gykB+xNvOgQkfS+B3TXSQrkHNRrS9YhLobpAfyufb9sAAMzEfkiqdb4Zt8734O SILZ/7ZpNDTKsZu5RBnNqzu6I0aVz2Pm6UwbrADN1JaiBJTY1RxIpQ8G14sTOKDyExt3 o9eiEO1a50fkHutt/ua1fAjh1eJn36YAx397wuzPLpitziSR1xr/Bk5P+evQdqUYf4Pj iDEw== X-Gm-Message-State: APt69E0SgLf1CFwmfimJjdUq7f+Cswb7CZfXZ0gLXHGwlbUSiD5A3/8y zYfk8SJK6XKDsjT8zhFq8zrSUeiR X-Google-Smtp-Source: ADUXVKIYSzIkTXwxP3wZA+r1OPnc97WfsDFWs1FrEENsHG7KWevX971+fUKmu+xb/hZT0O22ow+org== X-Received: by 2002:a24:1a10:: with SMTP id 16-v6mr5566498iti.66.1529175230705; Sat, 16 Jun 2018 11:53:50 -0700 (PDT) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com. [209.85.214.43]) by smtp.gmail.com with ESMTPSA id g17-v6sm2113431iti.1.2018.06.16.11.53.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Jun 2018 11:53:50 -0700 (PDT) Received: by mail-it0-f43.google.com with SMTP id u4-v6so7006681itg.0; Sat, 16 Jun 2018 11:53:49 -0700 (PDT) X-Received: by 2002:a24:100f:: with SMTP id 15-v6mr5252260ity.61.1529175229868; Sat, 16 Jun 2018 11:53:49 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:5995:0:0:0:0:0 with HTTP; Sat, 16 Jun 2018 11:53:49 -0700 (PDT) In-Reply-To: References: <201806110842.w5B8g4we013345@repo.freebsd.org> From: Conrad Meyer Date: Sat, 16 Jun 2018 11:53:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334947 - head/sys/modules To: Kurt Lidl Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2018 19:21:48 -0000 r255185 added _mm_aesenc(), etc, but not _mm_sha*(). That's probably where the report comes from. (If you feel it is worth your while adding sha intrinsics to a decade-old GCC, go ahead, but I think gcc 4.2 on x86 is pretty dead.) Best, Conrad On Sat, Jun 16, 2018 at 7:57 AM, Kurt Lidl wrote: > On 6/11/18 4:42 AM, Dimitry Andric wrote: >> >> Author: dim >> Date: Mon Jun 11 08:42:03 2018 >> New Revision: 334947 >> URL: https://svnweb.freebsd.org/changeset/base/334947 >> >> Log: >> Disable building aesni with base gcc >> Because base gcc does not support the required intrinsics, do not >> attempt to compile the aesni module with it. >> Noticed by: Dan Allen >> MFC after: 3 days >> >> Modified: >> head/sys/modules/Makefile >> >> Modified: head/sys/modules/Makefile >> >> ============================================================================== >> --- head/sys/modules/Makefile Mon Jun 11 08:11:35 2018 (r334946) >> +++ head/sys/modules/Makefile Mon Jun 11 08:42:03 2018 (r334947) >> @@ -627,7 +627,9 @@ _aac= aac >> _aacraid= aacraid >> _acpi= acpi >> .if ${MK_CRYPT} != "no" || defined(ALL_MODULES) >> +.if ${COMPILER_TYPE} != "gcc" || ${COMPILER_VERSION} > 40201 >> _aesni= aesni >> +.endif >> .endif >> _amd_ecc_inject=amd_ecc_inject >> _amdsbwd= amdsbwd >> > > I thought that FreeBSD's base gcc (but not a stock 4.2.1 gcc) had support > for this. As documented in UPDATING: > > 20130903: > AES-NI intrinsic support has been added to gcc. The AES-NI module > has been updated to use this support. A new gcc is required to build > the aesni module on both i386 and amd64. > > -Kurt >