From nobody Wed Mar 1 01:48:37 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRHFs6X0Fz3vD3x for ; Wed, 1 Mar 2023 01:48:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRHFs4mRzz3DDS for ; Wed, 1 Mar 2023 01:48:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52f.google.com with SMTP id ee7so47987117edb.2 for ; Tue, 28 Feb 2023 17:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1677635328; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qvE4R8X2h8fvK9K+l7FrYNSQjX8rRfeoxQoMwLFUhUg=; b=AfHJAxNF73IDaiuP3QGfNBzCGoZW/Tik1TBw5Sq53Nfxe534gGwWfetJYfij/i134m H292lAewFWD6nR4jgXm2nBOH5Hc/mBU2rvmEILxXY9wHS69yJwukCZVDFc9/kHHA3OKN tz7aEChXaYVv8QIC/oOTLx15t0kS84ZF5YI1/a8jXoWc3R0tcIT5BRmvtBf1ZOzeVjr9 TaEpxby32/UepRZmgHz30XYbqcufTsfX8NjsSxmMdm8e2pBCmlAiOTNGazJRlWIu75iv rfyNXdow4EbtOEi+2ZGHo7jdQwJjSGGcZ7PmI3RUd0aEsvkaxxLk0BeztmIMiZCqmkNz BMUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677635328; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qvE4R8X2h8fvK9K+l7FrYNSQjX8rRfeoxQoMwLFUhUg=; b=5Y1b/ljiE9JGX1jp2p+kuQsh5ub9aPPkJB4OgX3JI4aI88FXTGF5OhGW4jvscMLs9l icpVkc+5+BZSI0fYn/zAEthN/rTweOXhEq2wdUq/syF1IJunTr45gDNz0jXrQdQqJX4M Abb2M4lIG62wYLcqOq2SPfl1ER2rXfxRxNrLg3cl3+MV24pkovevh5LrT9/lOziXq4Jq X7IMaukdDd+98g8EJcCgvJdcZGIXT6B864H9n8fBWgYteDfuC2NpCz02Ya+sEvs7zIcf OmvnLCtDG5TgQV0p8npBkU1UsWEmy/9TkO37xNFCkJ/mF07RpFtauskUm3cNiWyAvYtK jIPw== X-Gm-Message-State: AO0yUKVlmrtbpfw6UmannXHA93P6HfjAXvKdThRZklqdxMJx5Uwl+Fj9 M0Wjxu3k8wecKWc0z5Bsu5e8YQkTUORQROcDxAkjAyDIrewkvQ== X-Google-Smtp-Source: AK7set//rikDOcSfSSaAPdxFxmN6b/twx9qxjbnhgIofnDsPK6VQ8x7vk88dgepdhClcrJqP6xm/+smcbJYSlk2lOIg= X-Received: by 2002:a17:906:5597:b0:8b1:7aec:c8e6 with SMTP id y23-20020a170906559700b008b17aecc8e6mr2290023ejp.2.1677635328235; Tue, 28 Feb 2023 17:48:48 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Tue, 28 Feb 2023 18:48:37 -0700 Message-ID: Subject: Re: Report on the pull request experiment so far To: Brooks Davis Cc: Ed Maste , freebsd-git Content-Type: multipart/alternative; boundary="000000000000cd6b2f05f5cce992" X-Rspamd-Queue-Id: 4PRHFs4mRzz3DDS X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000cd6b2f05f5cce992 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 28, 2023, 4:04 PM Brooks Davis wrote: > On Tue, Feb 28, 2023 at 05:12:37PM -0500, Ed Maste wrote: > > On Sat, 25 Feb 2023 at 18:54, Warner Losh wrote: > > > > > > I also landed one commit that was from 2021. Yikes. The commit date is > right, but the author date is in the past. I suggest that we add a git > commit --amend --date="`date`" to the process. This likely is a good thing. > There's no simple --reset-date, alas: only a reset that also resets the > author. > > > > IMO we should just accept git's notion of separate author and commit > > dates, and not worry about author dates being in the past. > > I remain on the fence, but think we should either accept git's notion or > enforce that the date is newer than prior commits and not in the future. > IMO we should enforce this on commit dates regardless[0]. There is no > conceivable value in allowing people to commit from systems with wildly > wrong clocks given they must be on the internet to commit. > I too am on the fence. It isn't a huge deal... I've also found git am --ignore-date copes well. It's a lot faster to fetch the .patch file and feed it to git am than to fetch the deltas and rebase... but the latter is more robust... A bigger issue in my mind is the project's use of trailer metadata that doesn't match what git expects. The whole spaces vs - thing is making tooling harder than it needs to be... Warner -- Brooks > > [0] Obviously this only applies to first-parent commits not the commits > being merged in a merge commit. > --000000000000cd6b2f05f5cce992 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Feb 28, 2023, 4:04 PM Brooks Davis <brooks@freebsd.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On Tue, Feb 28, 2023 at 05:12:37PM -0500, Ed = Maste wrote:
> On Sat, 25 Feb 2023 at 18:54, Warner Losh <imp@bsdimp.com> wrote= :
> >
> > I also landed one commit that was from 2021. Yikes. The commit da= te is right, but the author date is in the past. I suggest that we add a gi= t commit --amend --date=3D"`date`" to the process. This likely is= a good thing. There's no simple --reset-date, alas: only a reset that = also resets the author.
>
> IMO we should just accept git's notion of separate author and comm= it
> dates, and not worry about author dates being in the past.

I remain on the fence, but think we should either accept git's notion o= r
enforce that the date is newer than prior commits and not in the future. IMO we should enforce this on commit dates regardless[0].=C2=A0 There is no=
conceivable value in allowing people to commit from systems with wildly
wrong clocks given they must be on the internet to commit.
=

I too am on the f= ence. It isn't a huge deal...=C2=A0

I've also found git am --ignore-date copes well. It'= ;s a lot faster to fetch the .patch file and feed it to git am than to fetc= h the deltas and rebase... but the latter is more robust...

A bigger issue in my mind is the proj= ect's use of trailer metadata that doesn't match what git expects. = The whole spaces vs - thing is making tooling harder than it needs to be...=

Warner=C2=A0

-- Brooks

[0] Obviously this only applies to first-parent commits not the commits
being merged in a merge commit.
--000000000000cd6b2f05f5cce992--