From owner-cvs-sys Sun Sep 21 16:28:31 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id QAA24740 for cvs-sys-outgoing; Sun, 21 Sep 1997 16:28:31 -0700 (PDT) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id QAA24730; Sun, 21 Sep 1997 16:28:20 -0700 (PDT) Received: (from root@localhost) by dyson.iquest.net (8.8.6/8.8.5) id SAA03748; Sun, 21 Sep 1997 18:28:09 -0500 (EST) From: "John S. Dyson" Message-Id: <199709212328.SAA03748@dyson.iquest.net> Subject: Re: cvs commit: src/sys/net ppp_deflate.c In-Reply-To: <199709212257.QAA28083@rocky.mt.sri.com> from Nate Williams at "Sep 21, 97 04:57:34 pm" To: nate@mt.sri.com (Nate Williams) Date: Sun, 21 Sep 1997 18:28:09 -0500 (EST) Cc: dyson@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL31 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Nate Williams said: > John Dyson writes: > > dyson 1997/09/21 15:31:22 PDT > > > > Modified files: > > sys/net ppp_deflate.c > > Log: > > Remove an unfortunate name clash with the zalloc/zfree routines. Since the > > ppp_deflate code uses the names locally - it looses. > > Since the ppp code is 'externally' maintained code, did you submit this > patch to the author? If not, then we have to keep maintaining this > change everytime we update it, which would imply that it would be easier > to change the 'locally' maintained code. > > (Also, changing legacy code that uses names recently introduced seems > silly, since the old names already existed.) > I disagree, when it was taking up global namespace unnecessarily. I knew that there might be a bit of a controversy, but zalloc for the zone allocator seems to be make sense more, globally, than using it as zlib_alloc (which it should have been named originally, making more sense.) Sorry, but I disagree here. -- John dyson@freebsd.org jdyson@nc.com