From owner-svn-ports-head@freebsd.org Wed Apr 18 17:49:56 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E9E1F9DA2A; Wed, 18 Apr 2018 17:49:56 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-ua0-x231.google.com (mail-ua0-x231.google.com [IPv6:2607:f8b0:400c:c08::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B03D56BD76; Wed, 18 Apr 2018 17:49:55 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: by mail-ua0-x231.google.com with SMTP id j18so1694398uae.12; Wed, 18 Apr 2018 10:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=FGiYllSJ7mkKniJhGzZOK1VMHTPJ4HRaPdf4TnIgyKw=; b=m1QzWqkWAg1NetAqLKyHIFCJayz0Ubbqpug0z2mxY+MIBZlU+zOuDKpd2z3DFtdtOV +yhWtWP963+IVXXhuVMFIZVO+8RP/1g/zGcEfJOKwFJ6JrcMnCIQQw+UsboeMlCmrdXd 1iNPbwK+v9r1FQPndIk7ZD1hxrzhAiFW+5J9++MCPdAatpedqyAw8VEA2NDdYKm2Nf7l t9Tmc0V+An/gtwY+A4ve0+ltHrEeenjCI23MhU7ck7jK9COSx0Cqkx/Wb+Lt0X21iY5p ehUwO+fzvf4MTCyaqR5avj2FQqoQXRozjwvZdBBxLbrtje4i8vefQE4aGGJEr13qvqGy VcvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=FGiYllSJ7mkKniJhGzZOK1VMHTPJ4HRaPdf4TnIgyKw=; b=bHA3Tf/rw6pLsXioOq2x4evLrwoxmve8/oNkMjQD33c4wkjSvXD0i2sbbQHCKrqzR7 9mYFzJPdYn3ZacetMxY0PBBhV87OLMivR61+up5IKF/CSSAcDjXpoTrvqm3VGxU1woPv 9QicsqtD52XvaNdbosIOmbINwKwGg4Mo1MxumCvgVlNPVqxxrKv97AzC98IukR3fYXtq WwiB3+fY9bnVaxP7VcqJXneKOxqwmND0QrLy7prJDV7z534HaeCJ2JUbIVXTbvficg2z Gk7xbkHcRUwyvaK+RK9jmfckZy6+Ccptxwafb2ZAkthW0QFP08JC6qxYqe7JG7FOiCc/ E4Jg== X-Gm-Message-State: ALQs6tAF4/dCvyzmzgKEZTulpS7Yvmfk9s9nlQQGlUrtuJI92XquSYvw k8DwiUWJoJC2bhJTThX5H5F1ZOeh2MGUjejNqtp7nQ== X-Google-Smtp-Source: AIpwx4+l5w1ClgzEn0W6azmvFKpbZnq/eo/gPLAZCV+gu+6USngYY4MLeItJ4Xy0odmOhm9O6N6GDfbky57nwehubZ8= X-Received: by 10.176.82.50 with SMTP id i47mr2284666uaa.12.1524073793595; Wed, 18 Apr 2018 10:49:53 -0700 (PDT) MIME-Version: 1.0 Sender: bsdkaffee@gmail.com Received: by 10.31.48.151 with HTTP; Wed, 18 Apr 2018 10:49:52 -0700 (PDT) In-Reply-To: <20180418111002.b7ocgnvfo25s5ofk@ogg.in.absolight.net> References: <201804172327.w3HNRLIF044763@repo.freebsd.org> <20180418080556.lh6ds7t6e34ackoi@atuin.in.mat.cc> <3174473.pFhRGbBKQR@beastie.bionicmutton.org> <20180418111002.b7ocgnvfo25s5ofk@ogg.in.absolight.net> From: "Jason E. Hale" Date: Wed, 18 Apr 2018 13:49:52 -0400 X-Google-Sender-Auth: FJ3ZfElm7RlIVY3oIqzOd9zP6bg Message-ID: Subject: Re: svn commit: r467663 - in head/audio: . liblastfm liblastfm-qt5 liblastfm/files To: Mathieu Arnold Cc: Adriaan de Groot , ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 17:49:56 -0000 On Wed, Apr 18, 2018 at 7:10 AM, Mathieu Arnold wrote: > On Wed, Apr 18, 2018 at 10:21:16AM +0200, Adriaan de Groot wrote: >> On Wednesday, 18 April 2018 10:05:56 CEST Mathieu Arnold wrote: >> > On Tue, Apr 17, 2018 at 11:27:21PM +0000, Jason E. Hale wrote: >> > > Log: >> > > - Update audio/liblastfm to 1.0.9-5-g4433165 [1] >> > > - Add audio/liblastfm-qt5 slave port which provides a Qt 5 interface [1] >> > >> > Why not add flavors instead of a slave port? >> >> >> In an existing review https://reviews.freebsd.org/D14660 you (Mat) say of a >> different port >> >> """We currently do not accept flavors that add new packages though, so this >> change will be able to go in when ports-mgmt/poudriere is updated to 3.3.""" >> >> That would preclude flavorizing liblastfm, wouldn't it? There are a lot of Qt4/ >> Qt5 ports that could be flavorized and/or swept together like that. > > Mmmm, that sentence is not true any more, 3.3 was supposed to be the > first release to have the 32k packages limit fix, but as it was taking a > bit more time to get there, to the fix was backported to the 3.2 branch > and is in 3.2.6. So, flavorizing is possible now. (Still requires > portmgr approval.) > > I did submit a review for this (https://reviews.freebsd.org/D14667) a month ago and you rejected it, so I decided to move forward. Poudriere still has a bug in it where it is flavorizing the WRKDIR of the math/fftw3 dependency, however, which causes the build to fail without that ugly hack I put in. The port builds fine outside of poudriere without the hack. I did set up the port to be easily converted to FLAVORS, but maybe that bug should be fixed first before I re-attempt? - Jason