From owner-freebsd-stable@FreeBSD.ORG Fri Dec 27 19:05:39 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 62CCC6FE for ; Fri, 27 Dec 2013 19:05:39 +0000 (UTC) Received: from nm11-vm1.bullet.mail.bf1.yahoo.com (nm11-vm1.bullet.mail.bf1.yahoo.com [98.139.213.152]) by mx1.freebsd.org (Postfix) with SMTP id 07A4D1749 for ; Fri, 27 Dec 2013 19:05:38 +0000 (UTC) Received: from [98.139.212.152] by nm11.bullet.mail.bf1.yahoo.com with NNFMP; 27 Dec 2013 18:58:55 -0000 Received: from [68.142.230.65] by tm9.bullet.mail.bf1.yahoo.com with NNFMP; 27 Dec 2013 18:58:55 -0000 Received: from [127.0.0.1] by smtp222.mail.bf1.yahoo.com with NNFMP; 27 Dec 2013 18:58:55 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1388170734; bh=RUgVQMj/Y229O4PumSi8jK4HvGAXgVa9G0nkZT1IVpY=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer:Content-Transfer-Encoding; b=vSp5tiskcwQvCvefIo37A4IjOFUwNYELlFkRfsaE4euEAEn3SiBL9n7flM0grVcgOzdqosy2WLGPcWNI2+F43gVGLe00Fln7nS4mnqhob67zcgMEtHve9fhGigr/zdhtWFjXJp27VY6svCgxwI1CFWrwr615/yLNKOzDnTW3OoM= X-Yahoo-Newman-Id: 997540.64470.bm@smtp222.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: ZR0KonsVM1kODvc01LqEfN15HHDKUTFwQBcwzXCt.tlV2zw nCxT2uPJ3AIgg5_cSoALsaNNoyvv8UwipM6yxj9RmO1MMflynz_F9pXSgiux K_R7Iq.0dXf2KzBbGU492So6KGO_KdJDQUZUB43KaDy_86nGXRX4VEr6.ETi sxfY1FSSeU4xSo_FQAQNvleWTpFPm4YkeYytVck_FlbAfdVMz1KfjR2Q.FGO tdVOg4vJG.GiP4FWp64_aSCBALkDOVigcI7xEw9U.tMwBQ7b_W.yX.0zglqj 2UFOSlw85fa15ixB6ob4Bwk3_KuHXmTKCs5OeeSUljInye9ux1mXPj_2oty0 qYohcXflIFOCEZuOPexUszhYxi2pGfQNUbO15s_gNwDeYBSnK_JXgY3JbNsl gqglpR1cirzBgTv1X1Dh0at.Vvm6p4_wFT7HiG5H0iR0hEZYM56HL.tA9tEv EvkiYYAY._3bO6CEo_7ODVRzh8ZSDHi2oWuZrgnsPe0H34TTWaR_e83h8Rzt qPbBHKBrzLVCgiLvZCUt5khHcwKUBH1LphbnJlg4St0fs2ttxCp8J7DY6DZp P_hQ- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [10.73.160.242] (sean_bruno@209.131.62.116 with plain [63.250.193.228]) by smtp222.mail.bf1.yahoo.com with SMTP; 27 Dec 2013 18:58:54 +0000 UTC Subject: Re: 10.0 BETA 3 with redports kernel panic From: Sean Bruno To: Konstantin Belousov , Peter Wemm , "freebsd-stable@freebsd.org" In-Reply-To: <1387818681.2431.0.camel@powernoodle.corp.yahoo.com> References: <1387473915.2494.0.camel@powernoodle.corp.yahoo.com> <20131219180833.GN59496@kib.kiev.ua> <1387479064.2494.5.camel@powernoodle.corp.yahoo.com> <1387492541.27693.5.camel@powernoodle.corp.yahoo.com> <20131220094835.GR59496@kib.kiev.ua> <1387554355.1491.4.camel@powernoodle.corp.yahoo.com> <20131220162254.GT59496@kib.kiev.ua> <20131221145534.GY59496@kib.kiev.ua> <1387818681.2431.0.camel@powernoodle.corp.yahoo.com> Content-Type: text/plain; charset="us-ascii" Date: Fri, 27 Dec 2013 10:58:52 -0800 Message-ID: <1388170732.1530.2.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: decke X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: sbruno@freebsd.org List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Dec 2013 19:05:39 -0000 On Mon, 2013-12-23 at 09:11 -0800, Sean Bruno wrote: > On Sat, 2013-12-21 at 16:55 +0200, Konstantin Belousov wrote: > > > The reason why the dmaplimit change originally exploded was becase > > > dmaplimit is set to zero for the duration of while we're running on > > > the page tables given to us by the loader. I believe initializing > > > dmaplimit to DMAP_MAX_ADDRESS rather than zero would have solved the > > > original explosions. > > The dmaplimit is initialized in > > hammer_time->pmap_bootstrap->getmemsize-> > > create_pagetable(). The backtrace above should be much later in the > > boot sequence, note that mi_startup() was already running. > > > > I believe that my previous change just broke vsetslab()/vtoslab(). > > Currently running 2/4 machines with the following patch. No data for > stability yet. Still waiting. > > > > Index: amd64/amd64/mem.c > > =================================================================== > > --- amd64/amd64/mem.c (revision 258554) > > +++ amd64/amd64/mem.c (working copy) > > @@ -98,6 +98,10 @@ > > kmemphys: > > o = v & PAGE_MASK; > > c = min(uio->uio_resid, (u_int)(PAGE_SIZE - o)); > > + v = PHYS_TO_DMAP(v); > > + if (v < DMAP_MIN_ADDRESS || v >= dmaplimit || > > + pmap_kextract(v) == 0) > > + return (EFAULT); > > error = uiomove((void *)PHYS_TO_DMAP(v), (int)c, uio); > > continue; > > } > > Index: amd64/amd64/pmap.c > > =================================================================== > > --- amd64/amd64/pmap.c (revision 258554) > > +++ amd64/amd64/pmap.c (working copy) > > @@ -321,7 +321,7 @@ > > "Number of kernel page table pages allocated on bootup"); > > > > static int ndmpdp; > > -static vm_paddr_t dmaplimit; > > +vm_paddr_t dmaplimit; > > vm_offset_t kernel_vm_end = VM_MIN_KERNEL_ADDRESS; > > pt_entry_t pg_nx; > > > > Index: amd64/include/pmap.h > > =================================================================== > > --- amd64/include/pmap.h (revision 258554) > > +++ amd64/include/pmap.h (working copy) > > @@ -368,6 +368,7 @@ > > extern vm_paddr_t dump_avail[]; > > extern vm_offset_t virtual_avail; > > extern vm_offset_t virtual_end; > > +extern vm_paddr_t dmaplimit; > > > > #define pmap_page_get_memattr(m) ((vm_memattr_t)(m)->md.pat_mode) > > #define pmap_page_is_write_mapped(m) (((m)->aflags & PGA_WRITEABLE) != 0) Update from redports land. I've added the patches for "keep java from crashing the box" to these machines as they have manifested the problem once. I have not seen the original panic str of: panic: vm_fault: fault on nofault entry, addr: fffffe0327240000 So, the current diff looks like this: Index: sys/amd64/amd64/mem.c =================================================================== --- sys/amd64/amd64/mem.c (revision 258556) +++ sys/amd64/amd64/mem.c (working copy) @@ -97,7 +97,15 @@ v = uio->uio_offset; kmemphys: o = v & PAGE_MASK; + v = PHYS_TO_DMAP(v); + if (v < DMAP_MIN_ADDRESS || v >= DMAP_MAX_ADDRESS || + pmap_kextract(v) == 0) + return (EFAULT); c = min(uio->uio_resid, (u_int)(PAGE_SIZE - o)); + v = PHYS_TO_DMAP(v); + if (v < DMAP_MIN_ADDRESS || v >= dmaplimit || + pmap_kextract(v) == 0) + return (EFAULT); error = uiomove((void *)PHYS_TO_DMAP(v), (int)c, uio); continue; } Index: sys/amd64/amd64/pmap.c =================================================================== --- sys/amd64/amd64/pmap.c (revision 258556) +++ sys/amd64/amd64/pmap.c (working copy) @@ -321,7 +321,7 @@ "Number of kernel page table pages allocated on bootup"); static int ndmpdp; -static vm_paddr_t dmaplimit; +vm_paddr_t dmaplimit; vm_offset_t kernel_vm_end = VM_MIN_KERNEL_ADDRESS; pt_entry_t pg_nx; Index: sys/amd64/include/pmap.h =================================================================== --- sys/amd64/include/pmap.h (revision 258556) +++ sys/amd64/include/pmap.h (working copy) @@ -368,6 +368,7 @@ extern vm_paddr_t dump_avail[]; extern vm_offset_t virtual_avail; extern vm_offset_t virtual_end; +extern vm_paddr_t dmaplimit; #define pmap_page_get_memattr(m) ((vm_memattr_t)(m)->md.pat_mode) #define pmap_page_is_write_mapped(m) (((m)->aflags & PGA_WRITEABLE) != 0) Index: sys/vm/vm_map.c =================================================================== --- sys/vm/vm_map.c (revision 258556) +++ sys/vm/vm_map.c (working copy) @@ -1207,6 +1207,7 @@ } else if ((prev_entry != &map->header) && (prev_entry->eflags == protoeflags) && + (cow & (MAP_ENTRY_GROWS_DOWN | MAP_ENTRY_GROWS_UP)) == 0 && (prev_entry->end == start) && (prev_entry->wired_count == 0) && (prev_entry->cred == cred || @@ -3316,7 +3317,6 @@ * NOTE: We explicitly allow bi-directional stacks. */ orient = cow & (MAP_STACK_GROWS_DOWN|MAP_STACK_GROWS_UP); - cow &= ~orient; KASSERT(orient != 0, ("No stack grow direction")); if (addrbos < vm_map_min(map) ||