From owner-freebsd-usb@FreeBSD.ORG Wed Aug 20 20:06:38 2008 Return-Path: Delivered-To: usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D94A31065671 for ; Wed, 20 Aug 2008 20:06:38 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx1.rink.nu (gloom.rink.nu [213.34.49.2]) by mx1.freebsd.org (Postfix) with ESMTP id A0F9E8FC24 for ; Wed, 20 Aug 2008 20:06:38 +0000 (UTC) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx1.rink.nu (Postfix) with ESMTP id 3948F6D453; Wed, 20 Aug 2008 21:48:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at rink.nu Received: from mx1.rink.nu ([213.34.49.2]) by localhost (gloom.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I1jIac6YWSkA; Wed, 20 Aug 2008 21:48:07 +0200 (CEST) Received: by mx1.rink.nu (Postfix, from userid 1000) id 73D856D450; Wed, 20 Aug 2008 21:48:07 +0200 (CEST) Date: Wed, 20 Aug 2008 21:48:07 +0200 From: Rink Springer To: Alfred Perlstein Message-ID: <20080820194807.GE33396@rink.nu> References: <20080819194413.GB16977@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080819194413.GB16977@elvis.mu.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: usb@freebsd.org Subject: Re: HEADSUP new usb code coming in. X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Aug 2008 20:06:38 -0000 Hi Alfred, On Tue, Aug 19, 2008 at 12:44:13PM -0700, Alfred Perlstein wrote: > http://mu.org/~bright/usb2/usb4bsd.diff.gz Whenever I try this patch, my build dies with: cc -c -O2 -pipe -fno-strict-aliasing -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I../../.. -I../../../contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -Werror ../../../dev/usb2/core/usb2_generic.c cc1: warnings being treated as errors ../../../dev/usb2/core/usb2_generic.c: In function 'ugen_ioctl': ../../../dev/usb2/core/usb2_generic.c:1409: warning: 'ep_index' may be used uninitialized in this function ../../../dev/usb2/core/usb2_generic.c:1409: note: 'ep_index' was declared here *** Error code 1 I'm using a small patch to get it to compile: - uint8_t ep_index; + uint8_t ep_index = 0; However, I am unsure if this is correct. Futhermore, 'device usb2_bluetooth' gives a lot of compile errors. Am I using the right patch here? Regards, -- Rink P.W. Springer - http://rink.nu "Anyway boys, this is America. Just because you get more votes doesn't mean you win." - Fox Mulder