From owner-freebsd-current@FreeBSD.ORG Sat Aug 21 17:36:23 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24EB816A4CE; Sat, 21 Aug 2004 17:36:23 +0000 (GMT) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35ED043D1F; Sat, 21 Aug 2004 17:36:22 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received-SPF: pass (mp2.macomnet.net: domain of maxim@macomnet.ru designates 127.0.0.1 as permitted sender) receiver=mp2.macomnet.net; client_ip=127.0.0.1; envelope-from=maxim@macomnet.ru; Received: from localhost (e2f8g7g2@localhost [127.0.0.1]) by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id i7LHZvmL036228; Sat, 21 Aug 2004 21:35:57 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Sat, 21 Aug 2004 21:35:57 +0400 (MSD) From: Maxim Konovalov To: Tim Kientzle In-Reply-To: <4127841D.6050104@freebsd.org> Message-ID: <20040821213426.A36214@mp2.macomnet.net> References: <1092777586.92327.9.camel@server.mcneil.com> <20040817213813.GE3827@gothmog.gr><4127841D.6050104@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Giorgos Keramidas cc: freebsd-current@freebsd.org cc: Sean McNeil Subject: Re: bsdtar core dumps X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2004 17:36:23 -0000 On Sat, 21 Aug 2004, 10:19-0700, Tim Kientzle wrote: [...] > The code you've pointed to above concerns > me because of the part about: > if (n == 0) { > ... > n = 1; > } > That ain't right: If I told vsnprintf the buffer > size was zero, it should treat it as such. If I > meant "one", I would have said "one." That code was committed in rev. 1.21 vsnprintf.c, a workaround for a memory leak, bin/36175. -- Maxim Konovalov