From nobody Tue Jan 24 22:13:00 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P1h711m0wz3bgHx; Tue, 24 Jan 2023 22:13:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P1h7105Q6z3FNg; Tue, 24 Jan 2023 22:13:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hBHnQcUhhGm3M0ufKRDIErVZhGuqRAWdUlBcUIk69q4=; b=ck8yfrNhzphx9uqSTZf2FNhce2QG1M6XiBWRNOt+O6r6UK1wiGY4yYBwUnuzUsD7CDMxkb /MCmyN3FQeJnQsgBnxogIP5PrBufYTtZQScQGwkZ6y9jIb0q0NlxzMD1IR0Un/1GjXnzIJ 75VFoh6zn5dln0SSnDwuKUEcIEPubdKWfjvrheov9GzbYD2lCT37xKE/wYudYGPHMTrFHD bfGEdxnDXNYqgtN5rGrUmtLn/CrkzlmMdE8oIaWWDBwBa38n/GIFGhRLY9VYfGMYOUWQlL sSn2nmw2nw4Jcte/gO7HPw9+h58s3nCvasK+y7EnCUogOYZ2umbVOTt3P76wvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hBHnQcUhhGm3M0ufKRDIErVZhGuqRAWdUlBcUIk69q4=; b=BE7Ol1jPs4UnB6j58/2HtEZV0+PLzlcNZg1NX5L+el0WMkzACrNIFBzCivqlT5xWUUsWtD gSR9HbLvg+jMNqWaNTgAdIG7AQ+n1vBYq/CY+JHLybJXF2FwNvuTfIpq3WiiY9kXUWPUTq Ggnx80YYe6y3OXmZgQ4ygpb06DIneC0ddNaMure5jwi9QSPvlx0QnozdQiNvs5gdl9ZJqG MRn9IR4pq1WgQYCwypWdRvpb6tIe9Nob66ertZGkPryKqttq7BK4MyzhO1QbVQWXolMRZo 3/xGVDP3a5GO6WIest+uSb8hR7slt3DWFo2RogenwATRKpbhn7s94+1U1QuwfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674598381; a=rsa-sha256; cv=none; b=UXQNgl7pAccXDP3NcmdhrHxr8im4/TVOulz0Wnj7M3FNO13NbAVxj2YeQWWJlTS123QI5p WaaKaUg2xfcZNPPH6IbCbDNYRWWH5pw5VYOdJX0BX3waGmYO4LwIY1o26nU1Ij5/wLPALt nB4p7lIomnPJt4/gP5xbVDb456HtLr9i5jRwcZwR4kLhnvqxKt4AqEJyLsw8SAS9P+tKVC +fGdvvPwGHCG3HqV2Jy6yUXoR1OxmJEgkZgZRQINvOAdzm9GAyUw4pXqyy9JN2WwjoEka6 B2xgewE26sVSMGAtLUq19F2F7PHytohSKea0JeQV42wnkMIbtXpiTEv+hSoP+Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P1h706K59zQk0; Tue, 24 Jan 2023 22:13:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30OMD0nh087828; Tue, 24 Jan 2023 22:13:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30OMD0En087827; Tue, 24 Jan 2023 22:13:00 GMT (envelope-from git) Date: Tue, 24 Jan 2023 22:13:00 GMT Message-Id: <202301242213.30OMD0En087827@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 665145887765 - stable/13 - stand: Update comment about devdesc List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 66514588776559991675e0959491885f939a0d5f Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=66514588776559991675e0959491885f939a0d5f commit 66514588776559991675e0959491885f939a0d5f Author: Warner Losh AuthorDate: 2022-11-05 01:45:27 +0000 Commit: Warner Losh CommitDate: 2023-01-24 21:49:37 +0000 stand: Update comment about devdesc How devdesc is used is opaque until much code is read. Give a more useful description of the theory behind it here. Sponsored by: Netflix (cherry picked from commit 269865a8eed240f572472750451484feccaeeeea) --- stand/libsa/stand.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/stand/libsa/stand.h b/stand/libsa/stand.h index 5ffff54c7ca7..3b2627355ed6 100644 --- a/stand/libsa/stand.h +++ b/stand/libsa/stand.h @@ -170,9 +170,14 @@ extern struct devsw netdev; extern int errno; /* - * Generic device specifier; architecture-dependent - * versions may be larger, but should be allowed to - * overlap. + * Generic device specifier; architecture-dependent versions may be larger, but + * should be allowed to overlap. The larger device specifiers store more data + * than can fit in the generic one that's gleaned after parsing the device + * string, or used in some cases to indicate wildcards that match a variety of + * situations based on what's on the drive itself rather than what the progammer + * might know in advance. Information about open files is stored in d_opendata, + * though what's passed into the open routine may differ from what's present + * after the open on some configurations. */ struct devdesc { struct devsw *d_dev;