From owner-freebsd-hackers Fri Jun 4 1:26:56 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from storm.FreeBSD.org.uk (storm.freebsd.org.uk [194.242.128.198]) by hub.freebsd.org (Postfix) with ESMTP id AFC071543F for ; Fri, 4 Jun 1999 01:26:52 -0700 (PDT) (envelope-from brian@keep.lan.Awfulhak.org) Received: from keep.lan.Awfulhak.org (keep.lan.Awfulhak.org [172.16.0.8]) by storm.FreeBSD.org.uk (8.9.3/8.9.3) with ESMTP id JAA23532; Fri, 4 Jun 1999 09:26:13 +0100 (BST) (envelope-from brian@keep.lan.Awfulhak.org) Received: from keep.lan.Awfulhak.org (localhost [127.0.0.1]) by keep.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id JAA00520; Fri, 4 Jun 1999 09:14:00 +0100 (BST) (envelope-from brian@keep.lan.Awfulhak.org) Message-Id: <199906040814.JAA00520@keep.lan.Awfulhak.org> X-Mailer: exmh version 2.0.2 2/24/98 To: Bill Fumerola Cc: Brian Somers , dyson@iquest.net, Amancio Hasty , Matthew Dillon , "David E. Cross" , freebsd-hackers@FreeBSD.ORG, schimken@cs.rpi.edu Subject: Re: 3.2-stable, panic #12 In-reply-to: Your message of "Thu, 03 Jun 1999 17:51:39 EDT." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 04 Jun 1999 09:14:00 +0100 From: Brian Somers Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Fri, 4 Jun 1999, Brian Somers wrote: > > > The system was becoming unstable due to Matts changes. Whether the > > instabilities were in Matts code or somewhere else is irrelevent. > > The reaction was (IMHO) the right thing to do. > > I think where the problem lied is very relevent. > > If the problems are not his fault are you saying he should have backed > out his changes because they exposed old faulty code? What kind of > progress is that? I'm not saying he should have backed out his changes, I'm saying that they shouldn't have been made - that's why removing the commit bit was the right move. And just to head off the inevitable follow-up; for more trivial code, such a hostile reaction isn't necessary. There are lots of people around that can just fix the code, with the side-effect of giving the coder a subtle slap on the wrist. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message