From owner-freebsd-hackers@FreeBSD.ORG Sat Sep 6 15:16:44 2014 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 86A3CECD; Sat, 6 Sep 2014 15:16:44 +0000 (UTC) Received: from out145-ams.mf.surf.net (out145-ams.mf.surf.net [145.0.1.145]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 12923118E; Sat, 6 Sep 2014 15:16:43 +0000 (UTC) Received: from out42-ams.mf.surf.net (out42-ams.mf.surf.net [145.0.1.42]) by fbout1-ams.mf.surf.net (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id s86FB60t014982; Sat, 6 Sep 2014 17:11:06 +0200 Received: from smtps.utwente.nl (smtp-o1.utsp.utwente.nl [130.89.2.9]) by outgoing2-ams.mf.surf.net (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id s86FAwIt017491; Sat, 6 Sep 2014 17:10:58 +0200 Received: from [130.89.165.91] (nox.student.utwente.nl [130.89.165.91]) by smtps.utwente.nl (8.13.8) with ESMTP id s86FAvBt005511; Sat, 6 Sep 2014 17:10:58 +0200 Message-ID: <540B23F4.1040608@degoeje.nl> Date: Sat, 06 Sep 2014 17:10:44 +0200 From: Pieter de Goeje User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Konstantin Belousov , Adrian Chadd Subject: Re: mmap MAP_NOSYNC regression in 10.x References: <540903FF.6010602@degoeje.nl> <20140905080633.GM2737@kib.kiev.ua> <5409A4F8.6020204@degoeje.nl> <20140905123826.GP2737@kib.kiev.ua> <20140906074849.GS2737@kib.kiev.ua> In-Reply-To: <20140906074849.GS2737@kib.kiev.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Bayes-Prob: 0.0001 (Score 0, tokens from: utwente-out:default, base:default, @@RPTN) X-Spam-Score: -0.50 () [Tag at 5.00] 2450(0),CC(NL:-0.5) X-CanIt-Geo: ip=130.89.2.9; country=NL; region=Provincie Overijssel; city=Enschede; latitude=52.2195; longitude=6.8912; http://maps.google.com/maps?q=52.2195,6.8912&z=6 X-CanItPRO-Stream: utwente-out:default (inherits from utwente:default, base:default) X-Canit-Stats-ID: 0vMLPaWHg - 933dfbf3cab3 - 20140906 (trained as not-spam) X-Scanned-By: CanIt (www . roaringpenguin . com) Cc: Alan Cox , "freebsd-hackers@freebsd.org" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Sep 2014 15:16:44 -0000 Konstantin Belousov schreef op 6-9-2014 9:48: > On Fri, Sep 05, 2014 at 12:46:31PM -0700, Adrian Chadd wrote: >> Is this worth putting into the regression test suite? > I do not have opinion on this. Feel free to do if you consider it worth. > > Note that the code needs some tweaking to become automated test. > Also, there is no copyright assigned on the test, so you need > to handle this as well. > I can take a stab at converting it to something suitable for inclusion under tools/regression. One issue is that the test uses a heuristic to determine success or failure. I don't really see a way around that, although it certainly could be improved.