From owner-svn-src-all@FreeBSD.ORG Sun Mar 4 20:05:27 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 618A2106567F; Sun, 4 Mar 2012 20:05:27 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be [195.238.6.171]) by mx1.freebsd.org (Postfix) with ESMTP id 522338FC14; Sun, 4 Mar 2012 20:05:25 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EAOvJU09bsWcW/2dsb2JhbABDhTSvDYEIgX0BAQUjMyMQCw4GBCoCAjkeBogeB6ZukRqPR4EWBKVQgmQ Received: from 22.103-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.103.22]) by relay.skynet.be with ESMTP; 04 Mar 2012 21:05:18 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.5/8.14.5) with ESMTP id q24K5ISa008170; Sun, 4 Mar 2012 21:05:18 +0100 (CET) (envelope-from tijl@freebsd.org) From: Tijl Coosemans To: John Baldwin Date: Sun, 4 Mar 2012 21:05:09 +0100 User-Agent: KMail/1.13.7 (FreeBSD/10.0-CURRENT; KDE/4.7.3; i386; ; ) References: <201202281838.q1SIcYhE082928@svn.freebsd.org> <201203041351.22847.jhb@freebsd.org> In-Reply-To: <201203041351.22847.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1698307.50t2qeN2gg"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit Message-Id: <201203042105.15916.tijl@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232264 - in head/sys: amd64/include i386/include pc98/include x86/include X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Mar 2012 20:05:27 -0000 --nextPart1698307.50t2qeN2gg Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 04 March 2012 19:51:22 John Baldwin wrote: > On Tuesday, February 28, 2012 01:38:34 PM Tijl Coosemans wrote: >> Author: tijl >> Date: Tue Feb 28 18:38:33 2012 >> New Revision: 232264 >> URL: http://svn.freebsd.org/changeset/base/232264 >>=20 >> Log: >> Copy amd64 _stdint.h to x86 and merge with i386 _stdint.h. Replace >> amd64/i386/pc98 _stdint.h with stubs. >>=20 >> Added: >> head/sys/x86/include/_stdint.h >> - copied, changed from r232259, head/sys/amd64/include/_stdint.h >=20 > This broke C++ software (such as the audio/flac port), that #includes > with __STDC_LIMIT_MACROS defined but not __STDC_CONSTANT_MACRO= S=20 > defined. The problem is that you have changed UINT64_MAX and INT64_MAX t= o use=20 > UINT64_C() and INT64_C(), so in this case UINT64_MAX now expands to=20 > UINT64_C(...) which can't be resolved to a constant. >=20 > You should be able to reproduce this via the following: >=20 > % cat > bar.cc > #define __STDC_LIMIT_MACROS > #include > % c++ -c bar.cc >=20 > (The test to see if __WORDSIZE should be defined at the end of stdint.h t= rips=20 > over this bug.) >=20 > While you could do something like add __INT64_C() and __UINT64_C() macros= that=20 > are always defined and use them for INT64_MAX and UINT64_MAX, I think the= =20 > simplest fix is probably to just use #ifdef _LP64 tests to define INT64_M= AX=20 > and UINT64_MAX as pure constants as those are the only two macros effecte= d. >=20 > (I've just hardcoded those two constants on my little netbook so I can ke= ep=20 > building ports and that worked fine for audio/flac). =46ixed in r232519. --nextPart1698307.50t2qeN2gg Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EABEIAAYFAk9TyvsACgkQfoCS2CCgtisF9wD/SfvlMj3E2vfcD/7Mb6iUlJ1a fWY+7zWyjv18kcCuUlYA/3wQkD1hjPQW02PTS1+7GXEDLMoEFPLSIX9ltvGvG3Re =753o -----END PGP SIGNATURE----- --nextPart1698307.50t2qeN2gg--