From owner-cvs-sys Mon Aug 4 00:39:32 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id AAA19946 for cvs-sys-outgoing; Mon, 4 Aug 1997 00:39:32 -0700 (PDT) Received: from implode.root.com (implode.root.com [198.145.90.17]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA19940; Mon, 4 Aug 1997 00:39:29 -0700 (PDT) Received: from implode.root.com (localhost [127.0.0.1]) by implode.root.com (8.8.5/8.8.5) with ESMTP id AAA08057; Mon, 4 Aug 1997 00:41:38 -0700 (PDT) Message-Id: <199708040741.AAA08057@implode.root.com> To: Poul-Henning Kamp cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c In-reply-to: Your message of "Mon, 04 Aug 1997 00:30:46 PDT." <199708040730.AAA15522@freefall.freebsd.org> From: David Greenman Reply-To: dg@root.com Date: Mon, 04 Aug 1997 00:41:38 -0700 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >phk 1997/08/04 00:30:45 PDT > > Modified files: > sys/ufs/ffs ffs_alloc.c > Log: > We got a couple of "map mismatch" panics from the following > code. According to the crash dump, bpref is set to 445 > and cgp->cg_nclusterblks is 444. Hence in the for loop, > the test fails immediately but the following failure check > (got == cgp->cg_nclusterblks) doesn't trigger because got > > cgp->cg_nclusterblks. This wreaks havoc in the code after that. > > Fix: Move one source bit to the left :-) > > Noticed by: Mike Hibler > Submitted by: Kirk McKusick Just so people aren't confused: the above patch has no affect on FreeBSD; it's in an area of code that isn't even compiled. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project