From owner-freebsd-usb@FreeBSD.ORG  Wed Jun  8 16:00:25 2005
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
X-Original-To: freebsd-usb@hub.freebsd.org
Delivered-To: freebsd-usb@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2779E16A41C
	for <freebsd-usb@hub.freebsd.org>; Wed,  8 Jun 2005 16:00:25 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 053D243D1D
	for <freebsd-usb@hub.freebsd.org>; Wed,  8 Jun 2005 16:00:24 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j58G0OIo006638
	for <freebsd-usb@freefall.freebsd.org>; Wed, 8 Jun 2005 16:00:24 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j58G0Onc006637;
	Wed, 8 Jun 2005 16:00:24 GMT (envelope-from gnats)
Date: Wed, 8 Jun 2005 16:00:24 GMT
Message-Id: <200506081600.j58G0Onc006637@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
From: Hans Petter Selasky <hselasky@c2i.net>
Cc: 
Subject: Re: kern/68232: [patch] ugen(4) isochronous handling correction and
	tx support
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Hans Petter Selasky <hselasky@c2i.net>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2005 16:00:25 -0000

The following reply was made to PR kern/68232; it has been noted by GNATS.

From: Hans Petter Selasky <hselasky@c2i.net>
To: bug-followup@freebsd.org,
 matthew.gream@pobox.com
Cc:  
Subject: Re: kern/68232: [patch] ugen(4) isochronous handling correction and tx support
Date: Wed, 8 Jun 2005 17:54:52 +0200

 Hi,
 
 sce->isorate must be initialized somewhere. 
 Also it must be range checked.
 
 Is USBD_SET_RATE or USBD_GET_RATE documented somewhere.
 I think it is not so smart to pass the total number of 
 bytes per second. What is important is the frame size, 
 to synchronize data. Therefore USBD_SET_FRAME_SIZE and 
 USBD_GET_FRAME_SIZE would be better. And more generic! 
 Can you change this?
 
 Remember there is USB2.0 with 1000*8 frames per second.
 So USBD_SET_RATE might require two different values for 
 the same application, which is not very good.
 
 --HPS