Date: Wed, 8 Jun 2005 16:00:24 GMT From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-usb@FreeBSD.org Subject: Re: kern/68232: [patch] ugen(4) isochronous handling correction and tx support Message-ID: <200506081600.j58G0Onc006637@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/68232; it has been noted by GNATS. From: Hans Petter Selasky <hselasky@c2i.net> To: bug-followup@freebsd.org, matthew.gream@pobox.com Cc: Subject: Re: kern/68232: [patch] ugen(4) isochronous handling correction and tx support Date: Wed, 8 Jun 2005 17:54:52 +0200 Hi, sce->isorate must be initialized somewhere. Also it must be range checked. Is USBD_SET_RATE or USBD_GET_RATE documented somewhere. I think it is not so smart to pass the total number of bytes per second. What is important is the frame size, to synchronize data. Therefore USBD_SET_FRAME_SIZE and USBD_GET_FRAME_SIZE would be better. And more generic! Can you change this? Remember there is USB2.0 with 1000*8 frames per second. So USBD_SET_RATE might require two different values for the same application, which is not very good. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506081600.j58G0Onc006637>