Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Jun 2012 22:21:51 +0200
From:      Hans Petter Selasky <hselasky@c2i.net>
To:        Pawel Jakub Dawidek <pjd@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r236909 - head/sbin/hastd
Message-ID:  <201206112221.51793.hselasky@c2i.net>
In-Reply-To: <20120611200507.GG1399@garage.freebsd.pl>
References:  <201206111921.q5BJL0jP005127@svn.freebsd.org> <20120611200507.GG1399@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 11 June 2012 22:05:07 Pawel Jakub Dawidek wrote:
> On Mon, Jun 11, 2012 at 07:21:00PM +0000, Hans Petter Selasky wrote:
> > Author: hselasky
> > Date: Mon Jun 11 19:20:59 2012
> > New Revision: 236909
> > URL: http://svn.freebsd.org/changeset/base/236909
> > 
> > Log:
> >   Use the correct clock source when computing timeouts.
> 
> Could you please explain why? As you can see some lines above in
> cv_init(), we initialize condition variable with CLOCK_MONOTONIC too:
> 

Sorry, this was a mistake clearly. I will revert ASAP. Pointyhat to me.

My test program didn't take the setattr into account.

However, while at it, what is the default clock used by 
pthread_cond_timedwait(). In libusb we don't set any clock, and can we depend 
on that CLOCK_REALTIME is the default clock used? Else I should probably make 
a patch there.

man pthread_cond_timedwait() is silent!

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206112221.51793.hselasky>