From owner-svn-src-head@FreeBSD.ORG Mon Jun 11 20:22:26 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EFB87106566C; Mon, 11 Jun 2012 20:22:26 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe07.c2i.net [212.247.154.194]) by mx1.freebsd.org (Postfix) with ESMTP id D224F8FC15; Mon, 11 Jun 2012 20:22:25 +0000 (UTC) X-T2-Spam-Status: No, hits=-1.0 required=5.0 tests=ALL_TRUSTED Received: from [176.74.212.201] (account mc467741@c2i.net HELO laptop015.hselasky.homeunix.org) by mailfe07.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 284870614; Mon, 11 Jun 2012 22:22:24 +0200 From: Hans Petter Selasky To: Pawel Jakub Dawidek Date: Mon, 11 Jun 2012 22:21:51 +0200 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <201206111921.q5BJL0jP005127@svn.freebsd.org> <20120611200507.GG1399@garage.freebsd.pl> In-Reply-To: <20120611200507.GG1399@garage.freebsd.pl> X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@ =?iso-8859-15?q?d2+AyewRX=7DmAm=3BYp=0A=09=7CU=5B?=@, _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y> =?iso-8859-15?q?Y=7Dk1C4TfysrsUI=0A=09-=25GU9V5=5DiUZF=26nRn9mJ=27=3F=26?=>O MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201206112221.51793.hselasky@c2i.net> Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r236909 - head/sbin/hastd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2012 20:22:27 -0000 On Monday 11 June 2012 22:05:07 Pawel Jakub Dawidek wrote: > On Mon, Jun 11, 2012 at 07:21:00PM +0000, Hans Petter Selasky wrote: > > Author: hselasky > > Date: Mon Jun 11 19:20:59 2012 > > New Revision: 236909 > > URL: http://svn.freebsd.org/changeset/base/236909 > > > > Log: > > Use the correct clock source when computing timeouts. > > Could you please explain why? As you can see some lines above in > cv_init(), we initialize condition variable with CLOCK_MONOTONIC too: > Sorry, this was a mistake clearly. I will revert ASAP. Pointyhat to me. My test program didn't take the setattr into account. However, while at it, what is the default clock used by pthread_cond_timedwait(). In libusb we don't set any clock, and can we depend on that CLOCK_REALTIME is the default clock used? Else I should probably make a patch there. man pthread_cond_timedwait() is silent! --HPS