From owner-svn-ports-head@freebsd.org Fri Feb 8 13:32:13 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC73214E0B9F; Fri, 8 Feb 2019 13:32:12 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 92D2082A94; Fri, 8 Feb 2019 13:32:12 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 63519A263; Fri, 8 Feb 2019 13:32:12 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 160DF943601; Fri, 8 Feb 2019 13:32:10 +0000 (UTC) Date: Fri, 8 Feb 2019 14:32:09 +0100 From: Mathieu Arnold To: Michael Reifenberger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r492387 - head/cad/qcad Message-ID: <20190208133209.727347fetmup6tcz@ogg.in.absolight.net> References: <201902072236.x17Ma6SI012509@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zklfa4cnwcki3wwk" Content-Disposition: inline In-Reply-To: <201902072236.x17Ma6SI012509@repo.freebsd.org> User-Agent: NeoMutt/20180622 X-Rspamd-Queue-Id: 92D2082A94 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Feb 2019 13:32:13 -0000 --zklfa4cnwcki3wwk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 07, 2019 at 10:36:06PM +0000, Michael Reifenberger wrote: > +.include > + > +.if ${ARCH} =3D=3D "i386" > +CFLAGS_${ARCH}=3D -fPIC > +CXXFLAGS_${ARCH}=3D -fPIC > +.endif > + So, what this is doing, is setting CFLAGS_i386=3D -fPIC CXXFLAGS_i386=3D -fPIC Only if the arch is i386. As those variables are only ever used if the arch is i386, maybe you could forego the test and always set the *_i386 variables. (And rollback the bsd.port.pre.mk change too) --=20 Mathieu Arnold --zklfa4cnwcki3wwk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlxdhNlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkg0uhAAr/zZK27RQjrX/c1BQ51zP1iEZDh+RSY7K5fcfNm/WTitEsGkh9spksD6 y+THbm45uqYh6wgTB1UdGBReRwxGz9abkut2r463zZIxVMoST0TFfZd7UkRrLUZY igblbPbJUeYNhb9tgDBGYH7porbl6OCHActkK5UTHC3WQ6Eli2cx/+aMVGDwAU3a 9o7sGRSQpHNlLU6OpMgBWy/ecBXFgUa2bZuphTY0mJzQtXdTqVdA2GTck9nNbFNL Kh02Sb+22yyF+pJ8t0C2kjElceI7LI8y+AjfJSAdJQ6euNSnc+m6HXxzI7+SWHyT bN+bD8qnzSE/Fj+3PMzw1Zmt8S4vu3yeKu2rvjJ0hjn+XlSoK2yBZSRSJsEg0rQf kPmJJvs1nLU4zXQCvBVGkYw+5SEwWL5TzUdwRQaWUojeELc0Ncj+lpaPvJl8SQXk VJtUf+itdt34O8g2vl2GB3aHiG0gCaB2wszHqxZL2AV7SkvbTFAKVP/7g2J671EU 33MQxSmtuXQqGUdtx89lSmhpeBS3YB1mwzmlkgElddppsAT1OFk4gBiBTrZjgFvD VmP1xVYUGnEYZ1IEFJk6bWiOW5OpUBj6zZBQY0qHmkgKf/zZ2AmRfQlyR0HiYjSv cwRA+fERP3gAiWuXb1I8KzLgkbPzn+UkWoBAcwYno6IY9f9zUpQ= =Y28x -----END PGP SIGNATURE----- --zklfa4cnwcki3wwk--