From owner-svn-src-head@freebsd.org Tue Sep 8 22:44:39 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85733A00C1B; Tue, 8 Sep 2015 22:44:39 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 526AC112E; Tue, 8 Sep 2015 22:44:39 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by ioiz6 with SMTP id z6so2042766ioi.2; Tue, 08 Sep 2015 15:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wzommglTxDJ/Y18sRllGgrdU+2ZWS4pj5tV+0wMP8rY=; b=xA3TpxUmiEEos5y+DKIwzMOfEts3RprIpWCoNZpySJmQh9f3jDY9I4/fJa/JWhKKug 5gj93Bcr6tI9TD8HtMGAschqFN87OkroJZ+SZEwlVD6N5RuDJjU7b+HiNB7kqrYQrNHS eqexzHI/u8jPct8SK+kyan5x05QuonXlIDX4IT0pB/HxRh9vS8tI4nhHrQLSay5EkWeU N2MjxiUouqocRV+wp2hYROLEt8UgMbIr23BqrSJd80G793eT/PS/1Ob2EAbgQ9SArFEv uzlLVjJ7JzSniNCJP85BoYYQBkyNlZ4S/t5+TV4a6eflmFJ8SrcyvCl6KHWGJeK/Jax6 ur4Q== MIME-Version: 1.0 X-Received: by 10.107.13.75 with SMTP id 72mr43109200ion.75.1441752278623; Tue, 08 Sep 2015 15:44:38 -0700 (PDT) Received: by 10.36.28.208 with HTTP; Tue, 8 Sep 2015 15:44:38 -0700 (PDT) In-Reply-To: <201509082104.t88L4XaR095063@repo.freebsd.org> References: <201509082104.t88L4XaR095063@repo.freebsd.org> Date: Tue, 8 Sep 2015 15:44:38 -0700 Message-ID: Subject: Re: svn commit: r287578 - in head/usr.sbin/wpa: hostapd wpa_supplicant From: Adrian Chadd To: Jung-uk Kim Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2015 22:44:39 -0000 Wait a sec, did anyone review and test that this works out correctly? We already have working 802.11n; it's done inside net80211. It also mostly adds 20/40 coexistence and channel width changing on the fly, which is absolutely going to break absolutely everything as we don't /have/ stable support for that in any driver. Not only that, but mwl firmware for freebsd doesn't even fully work with 802.11n out of the box anyway, it has bugs with dealing with aggregation. sigh. So - please back this out and let's get this more thoroughly tested first. I don't want this update causing unpredictable behaviour. Thanks, -adrian On 8 September 2015 at 14:04, Jung-uk Kim wrote: > Author: jkim > Date: Tue Sep 8 21:04:33 2015 > New Revision: 287578 > URL: https://svnweb.freebsd.org/changeset/base/287578 > > Log: > Enable 802.11n support. > > PR: 164102 > > Modified: > head/usr.sbin/wpa/hostapd/Makefile > head/usr.sbin/wpa/wpa_supplicant/Makefile > > Modified: head/usr.sbin/wpa/hostapd/Makefile > ============================================================================== > --- head/usr.sbin/wpa/hostapd/Makefile Tue Sep 8 20:41:47 2015 (r287577) > +++ head/usr.sbin/wpa/hostapd/Makefile Tue Sep 8 21:04:33 2015 (r287578) > @@ -15,8 +15,8 @@ SRCS= accounting.c aes-omac1.c ap_config > eap_register.c eap_server.c eap_server_methods.c eap_user_db.c \ > eapol_auth_dump.c eapol_auth_sm.c eloop.c gas.c gas_serv.c hostapd.c \ > hs20.c http_client.c http_server.c httpread.c \ > - hw_features_common.c ieee802_11_auth.c \ > - ieee802_11_common.c ieee802_11_shared.c ieee802_1x.c ip_addr.c \ > + hw_features_common.c ieee802_11_auth.c ieee802_11_common.c \ > + ieee802_11_ht.c ieee802_11_shared.c ieee802_1x.c ip_addr.c \ > main.c ms_funcs.c os_unix.c peerkey_auth.c pmksa_cache_auth.c \ > preauth_auth.c radius.c radius_client.c radius_das.c sta_info.c \ > tkip_countermeasures.c upnp_xml.c utils.c uuid.c vlan_init.c \ > @@ -37,6 +37,7 @@ FILES= hostapd.conf hostapd.eap_user hos > CFLAGS+=-DCONFIG_DRIVER_BSD \ > -DCONFIG_DRIVER_RADIUS_ACL \ > -DCONFIG_HS20 \ > + -DCONFIG_IEEE80211N \ > -DCONFIG_INTERWORKING \ > -DCONFIG_PEERKEY \ > -DCONFIG_RSN_PREAUTH \ > > Modified: head/usr.sbin/wpa/wpa_supplicant/Makefile > ============================================================================== > --- head/usr.sbin/wpa/wpa_supplicant/Makefile Tue Sep 8 20:41:47 2015 (r287577) > +++ head/usr.sbin/wpa/wpa_supplicant/Makefile Tue Sep 8 21:04:33 2015 (r287578) > @@ -40,6 +40,7 @@ CFLAGS+=-DCONFIG_BACKEND_FILE \ > -DCONFIG_DRIVER_WIRED \ > -DCONFIG_GAS \ > -DCONFIG_HS20 \ > + -DCONFIG_IEEE80211N \ > -DCONFIG_IEEE80211R \ > -DCONFIG_INTERWORKING \ > -DCONFIG_PEERKEY \ >