From owner-svn-src-all@freebsd.org Wed Aug 26 05:31:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC2833C9F8D; Wed, 26 Aug 2020 05:31:28 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bbvc05Tv9z4hRH; Wed, 26 Aug 2020 05:31:28 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1598419888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GhFUoPji7VY/Fc+KeWkFp+zLTH7w8GX5r8x9Gg/xN2U=; b=Ts5Sz+l0MZZbfIdoGzvvrqV5PXxxFuitUDjcgCh10NnpE0VJG0TVay+EBqHTpxQMcTGlIs Wp0W/H6o3i2zZ2QeqrYXmpQU2Bx62syfS86GlATCkvC2H6H0KOzKnkMeAnqs2kUiIFiC0O typMiW1A2nOnBpWWwivuJKHnMMVLtn8gOgW7jMj2qPyNX5KWV/db6k5+L2rNOp0EJGzeZz wDH5auRvBrtU4/a7vPLQ8qwecu6GcTFNN1Pwxo4FCNLl6wrgSw8ttbRti6gtMnMLOmmdjj g6Ab0JN3MHrNOXdPLpgBGHSdT3BiyQnJxR/DMkOBYyntg1MB5fA1QpOyn8mgoQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id AD1FA9241; Wed, 26 Aug 2020 05:31:28 +0000 (UTC) Date: Wed, 26 Aug 2020 05:31:28 +0000 From: Alexey Dokuchaev To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364746 - in head: . cddl/compat/opensolaris/include cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd... Message-ID: <20200826053128.GA85697@FreeBSD.org> References: <202008250221.07P2LRST044836@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008250221.07P2LRST044836@repo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1598419888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GhFUoPji7VY/Fc+KeWkFp+zLTH7w8GX5r8x9Gg/xN2U=; b=mZJ2iLGnZDCrc68f89N4X6QA8BQJ1fvmOKyHd+DH032Jq3U4NG0ilH26qo+EKafooIvDbc ydmtgsYVrZlPykffFEATifc1E2Inld0pJhhVl1YKzbFaX8+b7euzu7Ro91rwnJreertCdw VHkXzuibGWWMXpmxrXL7zV2QcBUTmW2kQyF+An5dRRD+pi6EFLdxNLazGnjlSxIhwNz3Vr Lno6icbuxbalNYLA2zxOmflzMeNwYkc35+0xRibGAP0ibdYVqyCS6NGBiuBeTwxTWTJD+R Ll+F1TTNYIJMCpbIwzSHFFlfo6KGXF1JFwcm5M0gAjy+ps4SuPPv9EYZ9mwfXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1598419888; a=rsa-sha256; cv=none; b=BOYJYwemMv/PG6M4TXpN8yrxo+te3S5Ov64y/Aqk5HO1eiKrXBiRME3qy3955UlpDGJkTB y2qW4ayLmlmn42P1NxVke8aG894CUHQZrFqjE3Eq2cc7LOGwjU7l0pW0lIZ5K7hBZqECga 9JCKS9tamxN6EjsAaVPX8esyePkVWFhYVtS/dDp3pa6jasutK4bqaNMAsQqxB3/H3PWIgp UoTTN2Y059bDfNgoH/6IPZbHdIbesU+/om5UHVTkdQ6LDJIKEJMf/wiGWEaswVfviO4NxV pobWpLbW1NO3DQsF6oWZwkIRvSYECoyZYSTy52EXGPauLoTykdbpswRi+S8Hog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 05:31:28 -0000 On Tue, Aug 25, 2020 at 02:21:27AM +0000, Matt Macy wrote: > New Revision: 364746 > URL: https://svnweb.freebsd.org/changeset/base/364746 > > Log: > Merge OpenZFS support in to HEAD. > > The primary benefit is maintaining a completely shared > code base with the community allowing FreeBSD to receive > new features sooner and with less effort. This commit raises several questions. To start, I see a lot of things checked in under `sys/contrib/openzfs' which do not belong to the kernel (e.g. userland programs, libraries, manpages, bash completions, test suite, etc/sudoers.d) or FreeBSD at all (init.d, initramfs, systemd). Why those bits were not cleaned up, or at least kept on the vendor branch only? > Improvements include: > project quotas, encrypted datasets, > allocation classes, vectorized raidz, > vectorized checksums, various command line > improvements, zstd compression. And what about regressions? Would illumos (opensolaris) ZFS be also offered, maybe from ports, for those of us who prefer stable and highly reliable implementation? > Added: head/cddl/lib/libicp/Makefile > ... > + core/kcf_prov_lib.c \ > + core/kcf_callprov.c \ > + core/kcf_mech_tabs.c \ > + core/kcf_prov_tabs.c \ > + $(ASM_SOURCES_C) > + > + > + > + > + > + > +SRCS= $(ASM_SOURCES_AS) $(KERNEL_C) There are many excessive whitespace bugs, this is the most prominent. How did they pass the review? ./danfe