From owner-svn-src-head@FreeBSD.ORG  Mon Nov  5 21:33:59 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id A1F2F885;
 Mon,  5 Nov 2012 21:33:59 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id 6082E8FC12;
 Mon,  5 Nov 2012 21:33:58 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
 by mail.dawidek.net (Postfix) with ESMTPSA id 680ADEC8;
 Mon,  5 Nov 2012 22:32:20 +0100 (CET)
Date: Mon, 5 Nov 2012 22:34:48 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Jilles Tjoelker <jilles@FreeBSD.org>
Subject: Re: svn commit: r242620 - head/bin/sh
Message-ID: <20121105213448.GA1399@garage.freebsd.pl>
References: <201211051752.qA5HqI6m050154@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l"
Content-Disposition: inline
In-Reply-To: <201211051752.qA5HqI6m050154@svn.freebsd.org>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2012 21:33:59 -0000


--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 05, 2012 at 05:52:18PM +0000, Jilles Tjoelker wrote:
> Author: jilles
> Date: Mon Nov  5 17:52:18 2012
> New Revision: 242620
> URL: http://svnweb.freebsd.org/changeset/base/242620
>=20
> Log:
>   sh: Change cmdtype in tblentry from short to signed char.
>  =20
>   If this is a smaller type than int anyway, we can make it the smallest
>   possible.
>=20
> Modified:
>   head/bin/sh/exec.c
>=20
> Modified: head/bin/sh/exec.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/bin/sh/exec.c	Mon Nov  5 17:50:40 2012	(r242619)
> +++ head/bin/sh/exec.c	Mon Nov  5 17:52:18 2012	(r242620)
> @@ -85,7 +85,7 @@ struct tblentry {
>  	struct tblentry *next;	/* next entry in hash chain */
>  	union param param;	/* definition of builtin function */
>  	int special;		/* flag for special builtin commands */
> -	short cmdtype;		/* index identifying command */
> +	signed char cmdtype;	/* index identifying command */

Why not simply 'char'?

>  	char rehash;		/* if set, cd done since entry created */
>  	char cmdname[];		/* name of command */
>  };

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--XsQoSWH+UP9D9v3l
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCYMPgACgkQForvXbEpPzRS6QCeLFh1UG0lcdWMSu9B2rRBWsi5
dCUAn0pUzpccJa/6YxHL7QU6MYXCj/bO
=pIte
-----END PGP SIGNATURE-----

--XsQoSWH+UP9D9v3l--