Date: Mon, 5 Nov 2012 22:34:48 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Jilles Tjoelker <jilles@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r242620 - head/bin/sh Message-ID: <20121105213448.GA1399@garage.freebsd.pl> In-Reply-To: <201211051752.qA5HqI6m050154@svn.freebsd.org> References: <201211051752.qA5HqI6m050154@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 05, 2012 at 05:52:18PM +0000, Jilles Tjoelker wrote: > Author: jilles > Date: Mon Nov 5 17:52:18 2012 > New Revision: 242620 > URL: http://svnweb.freebsd.org/changeset/base/242620 >=20 > Log: > sh: Change cmdtype in tblentry from short to signed char. > =20 > If this is a smaller type than int anyway, we can make it the smallest > possible. >=20 > Modified: > head/bin/sh/exec.c >=20 > Modified: head/bin/sh/exec.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/bin/sh/exec.c Mon Nov 5 17:50:40 2012 (r242619) > +++ head/bin/sh/exec.c Mon Nov 5 17:52:18 2012 (r242620) > @@ -85,7 +85,7 @@ struct tblentry { > struct tblentry *next; /* next entry in hash chain */ > union param param; /* definition of builtin function */ > int special; /* flag for special builtin commands */ > - short cmdtype; /* index identifying command */ > + signed char cmdtype; /* index identifying command */ Why not simply 'char'? > char rehash; /* if set, cd done since entry created */ > char cmdname[]; /* name of command */ > }; --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCYMPgACgkQForvXbEpPzRS6QCeLFh1UG0lcdWMSu9B2rRBWsi5 dCUAn0pUzpccJa/6YxHL7QU6MYXCj/bO =pIte -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121105213448.GA1399>