From owner-p4-projects@FreeBSD.ORG Sun Sep 23 20:13:20 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 98D1216A418; Sun, 23 Sep 2007 20:13:20 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B43B16A41A; Sun, 23 Sep 2007 20:13:20 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from swip.net (mailfe11.swip.net [212.247.155.65]) by mx1.freebsd.org (Postfix) with ESMTP id 9443813C457; Sun, 23 Sep 2007 20:13:19 +0000 (UTC) (envelope-from hselasky@freebsd.org) X-Cloudmark-Score: 0.000000 [] Received: from [85.19.218.45] (account mc467741@c2i.net [85.19.218.45] verified) by mailfe11.swip.net (CommuniGate Pro SMTP 5.1.10) with ESMTPA id 454118567; Sun, 23 Sep 2007 21:13:16 +0200 From: Hans Petter Selasky To: "Constantine A. Murenin" Date: Sun, 23 Sep 2007 21:13:33 +0200 User-Agent: KMail/1.9.7 References: <200709231625.l8NGPhaR097038@repoman.freebsd.org> <46F6A3C3.6010408@FreeBSD.org> In-Reply-To: <46F6A3C3.6010408@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709232113.34718.hselasky@freebsd.org> Cc: Perforce Change Reviews Subject: Re: PERFORCE change 126745 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2007 20:13:21 -0000 Hi Constantine, Thanks for your input and I _know_ that my code is not 100% style compliant. Most of the style misbehaves are probably there due to the way my "xemacs" autoformatting behaves. And I love curly brackets and parenthesis, by the way :-) My plan is to clean up all the style stuff by a small C-program in the end, because doing it by hand is waste of my time. Probably it will take less time to write that program than the actual manual edit when we are talking about doing alot of edits. It wonders me if such a tool already exists, because the code is technically OK. Anyone that wants to be a little more constructive and point towards where the FreeBSD style transformer program is? I assume it would be extremely useful to everyone that is forced to use multiple different styles depending on what project they are contributing to, like me. Then before commit I will run that script and verify the differences. And that's it. --HPS