From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jan 11 17:20:05 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4252C16A421 for ; Fri, 11 Jan 2008 17:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 18B5A13C459 for ; Fri, 11 Jan 2008 17:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0BHK4Vo038524 for ; Fri, 11 Jan 2008 17:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0BHK4be038523; Fri, 11 Jan 2008 17:20:04 GMT (envelope-from gnats) Resent-Date: Fri, 11 Jan 2008 17:20:04 GMT Resent-Message-Id: <200801111720.m0BHK4be038523@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Pietro Cerutti" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AD7916A417 for ; Fri, 11 Jan 2008 17:14:11 +0000 (UTC) (envelope-from gahr@gahr.ch) Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73]) by mx1.freebsd.org (Postfix) with ESMTP id B84A913C4E1 for ; Fri, 11 Jan 2008 17:14:10 +0000 (UTC) (envelope-from gahr@gahr.ch) Received: from 80-218-191-236.dclient.hispeed.ch ([80.218.191.236] helo=gahrtop.localhost) by cpanel03.rubas-s03.net with esmtpa (Exim 4.68) (envelope-from ) id 1JDNSL-0005os-4v for FreeBSD-gnats-submit@freebsd.org; Fri, 11 Jan 2008 18:14:09 +0100 Received: from gahrtop.localhost (localhost [127.0.0.1]) by gahrtop.localhost (Postfix) with ESMTP id 39CA550848 for ; Fri, 11 Jan 2008 18:12:22 +0100 (CET) Message-Id: <1200071542.17339@gahrtop.localhost> Date: Fri, 11 Jan 2008 18:12:22 +0100 From: "Pietro Cerutti" To: "FreeBSD gnats submit" X-Send-Pr-Version: gtk-send-pr 0.4.9 Cc: Subject: ports/119569: [patch] x11-wm/e16utils quote icon path in file menus X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2008 17:20:05 -0000 >Number: 119569 >Category: ports >Synopsis: [patch] x11-wm/e16utils quote icon path in file menus >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 11 17:20:04 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Pietro Cerutti >Release: FreeBSD 8.0-CURRENT i386 >Organization: >Environment: System: FreeBSD 8.0-CURRENT #20: Tue Jan 8 15:03:14 CET 2008 root@gahrtop.localhost:/usr/obj/usr/src/sys/MSI1034 >Description: Icon paths are not quoted in menu entries generated by e16menuedit. This leads to problems when a path containing spaces is used. >How-To-Repeat: >Fix: --- _e16utils.diff begins here --- --- files/patch-e16menuedit-0.1.orig 2008-01-11 18:08:30.000000000 +0100 +++ files/patch-e16menuedit-0.1 2008-01-11 18:09:18.000000000 +0100 @@ -45,8 +45,8 @@ #MAKEDEP = makedepend -f- -s'\# CUT' -- -Y $(CFLAGS) $(EXTRA_CFLAGS) $(INCLUDES) $(EXTRA_INCLUDES) -- # piece together variables ---- viewer_new.c Mon Aug 7 23:29:16 2006 -+++ viewer.c Mon Aug 7 23:34:38 2006 +--- viewer.c.orig 2000-04-16 22:40:03.000000000 +0200 ++++ viewer.c 2008-01-11 18:08:53.000000000 +0100 @@ -34,7 +34,7 @@ if (!file_to_load) return; @@ -83,3 +83,21 @@ } else realfile = g_strdup (file); +@@ -717,7 +717,7 @@ + if (G_NODE_IS_LEAF (node)) + { + /* It's an entry */ +- fprintf (fp, "\"%s\"\t%s\texec\t\"%s\"\n", ++ fprintf (fp, "\"%s\"\t\"%s\"\texec\t\"%s\"\n", + dat->desc[0] == '\0' ? "NULL" : dat->desc, + dat->icon[0] == '\0' ? "NULL" : dat->icon, + dat->params[0] == '\0' ? "" : dat->params); +@@ -725,7 +725,7 @@ + else + { + /* It's a submenu */ +- fprintf (fp, "\"%s\"\t%s\tmenu\t\"%s\"\n", ++ fprintf (fp, "\"%s\"\t\"%s\"\tmenu\t\"%s\"\n", + dat->desc[0] == '\0' ? "NULL" : dat->desc, + dat->icon[0] == '\0' ? "NULL" : dat->icon, + dat->params[0] == '\0' ? "" : dat->params); --- _e16utils.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: