From owner-p4-projects@FreeBSD.ORG  Sun Mar  5 21:48:00 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1C2A916A423; Sun,  5 Mar 2006 21:48:00 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CD8FB16A420
	for <perforce@freebsd.org>; Sun,  5 Mar 2006 21:47:59 +0000 (GMT)
	(envelope-from wsalamon@computer.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 991F043D45
	for <perforce@freebsd.org>; Sun,  5 Mar 2006 21:47:59 +0000 (GMT)
	(envelope-from wsalamon@computer.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k25LlxtQ092108
	for <perforce@freebsd.org>; Sun, 5 Mar 2006 21:47:59 GMT
	(envelope-from wsalamon@computer.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k25LlxaL092105
	for perforce@freebsd.org; Sun, 5 Mar 2006 21:47:59 GMT
	(envelope-from wsalamon@computer.org)
Date: Sun, 5 Mar 2006 21:47:59 GMT
Message-Id: <200603052147.k25LlxaL092105@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	wsalamon@computer.org using -f
From: Wayne Salamon <wsalamon@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 92819 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Mar 2006 21:48:00 -0000

http://perforce.freebsd.org/chv.cgi?CH=92819

Change 92819 by wsalamon@gretsch on 2006/03/05 21:47:32

	Audit the remaining required arguments for quotactl(), mkfifo(),
	and symlink() system calls.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#30 edit
.. //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#10 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#30 (text+ko) ====

@@ -191,6 +191,8 @@
 	int error;
 	struct nameidata nd;
 
+	AUDIT_ARG(cmd, uap->cmd);
+	AUDIT_ARG(uid, uap->uid);
 	if (jailed(td->td_ucred) && !prison_quotas)
 		return (EPERM);
 	mtx_lock(&Giant);
@@ -1316,6 +1318,7 @@
 	struct nameidata nd;
 	int vfslocked;
 
+	AUDIT_ARG(mode, mode);
 restart:
 	bwillwrite();
 	NDINIT(&nd, CREATE, LOCKPARENT | SAVENAME | MPSAFE | AUDITVNODE1,
@@ -1531,6 +1534,7 @@
 		if ((error = copyinstr(path, syspath, MAXPATHLEN, NULL)) != 0)
 			goto out;
 	}
+	AUDIT_ARG(text, syspath);
 restart:
 	bwillwrite();
 	NDINIT(&nd, CREATE, LOCKPARENT | SAVENAME | MPSAFE | AUDITVNODE1,

==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#10 (text+ko) ====

@@ -547,6 +547,12 @@
 		/* Header, subject, and return tokens added at end */
 		break;
 
+	case AUE_MKFIFO:
+		if (ARG_IS_VALID(kar, ARG_MODE)) {
+			tok = au_to_arg32(2, "mode", ar->ar_arg_mode);
+			kau_write(rec, tok);
+		}
+		/* fall through */
 	case AUE_ACCESS:
 	case AUE_CHDIR:
 	case AUE_CHROOT:
@@ -555,7 +561,6 @@
 	case AUE_GETATTRLIST:
 	case AUE_NFS_GETFH:
 	case AUE_LSTAT:
-	case AUE_MKFIFO:
 	case AUE_PATHCONF:
 	case AUE_READLINK:
 	case AUE_REVOKE: