Date: Thu, 27 Aug 2020 15:08:40 +0000 (UTC) From: "Jason E. Hale" <jhale@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r546351 - head/audio/taglib Message-ID: <202008271508.07RF8eMG077690@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhale Date: Thu Aug 27 15:08:40 2020 New Revision: 546351 URL: https://svnweb.freebsd.org/changeset/ports/546351 Log: audio/taglib: Fix packaging if TEST option is enabled - Add STATIC option to fix packaging if the TEST option is enabled. Taglib only allows for static libraries to be built when testing is enabled. [1] - devel/cppunit needs to be present at build time for the tests to be built. - Enable symbol visibility. - Boost support was removed upstream, so we no longer need to disable the check for it. PR: 246203 [1] Submitted by: <daniel.engberg.lists@pyret.net> [1] Reported by: <sdalu@sdalu.com> [1] Modified: head/audio/taglib/Makefile head/audio/taglib/pkg-plist Modified: head/audio/taglib/Makefile ============================================================================== --- head/audio/taglib/Makefile Thu Aug 27 14:45:38 2020 (r546350) +++ head/audio/taglib/Makefile Thu Aug 27 15:08:40 2020 (r546351) @@ -4,6 +4,7 @@ PORTNAME= taglib DISTVERSIONPREFIX= v DISTVERSION= 1.12-beta-1 +PORTREVISION= 1 CATEGORIES= audio MAINTAINER= jhale@FreeBSD.org @@ -21,11 +22,12 @@ USE_LDCONFIG= yes USE_GITHUB= yes -CMAKE_ON= CMAKE_DISABLE_FIND_PACKAGE_Boost \ +CMAKE_ARGS= -DCMAKE_CXX_VISIBILITY_PRESET=hidden +CMAKE_ON= VISIBILITY_HIDDEN \ WITH_ASF \ WITH_MP4 -OPTIONS_DEFINE= RCC TEST +OPTIONS_DEFINE= RCC STATIC TEST OPTIONS_SUB= yes # The official patches for this can be obtained from: @@ -36,9 +38,12 @@ RCC_LIB_DEPENDS= librcc.so:devel/librcc RCC_USES= localbase:ldflags RCC_EXTRA_PATCHES= ${FILESDIR}/extrapatch-rcc +STATIC_CMAKE_BOOL_OFF= BUILD_SHARED_LIBS + +TEST_BUILD_DEPENDS= cppunit-config:devel/cppunit TEST_CMAKE_BOOL= BUILD_TESTS -TEST_CMAKE_BOOL_OFF= BUILD_SHARED_LIBS -TEST_TARGET= check +TEST_TARGET= check +TEST_IMPLIES= STATIC post-patch-RCC-on: @${REINPLACE_CMD} -e 's|-ltag|-ltag -lrcc|g' \ Modified: head/audio/taglib/pkg-plist ============================================================================== --- head/audio/taglib/pkg-plist Thu Aug 27 14:45:38 2020 (r546350) +++ head/audio/taglib/pkg-plist Thu Aug 27 15:08:40 2020 (r546351) @@ -106,11 +106,13 @@ include/taglib/xingheader.h include/taglib/xiphcomment.h include/taglib/xmfile.h include/taglib/xmproperties.h -lib/libtag.so -lib/libtag.so.1 -lib/libtag.so.1.17.0 -lib/libtag_c.so -lib/libtag_c.so.0 -lib/libtag_c.so.0.0.0 +%%STATIC%%lib/libtag.a +%%NO_STATIC%%lib/libtag.so +%%NO_STATIC%%lib/libtag.so.1 +%%NO_STATIC%%lib/libtag.so.1.17.0 +%%STATIC%%lib/libtag_c.a +%%NO_STATIC%%lib/libtag_c.so +%%NO_STATIC%%lib/libtag_c.so.0 +%%NO_STATIC%%lib/libtag_c.so.0.0.0 libdata/pkgconfig/taglib.pc libdata/pkgconfig/taglib_c.pc
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008271508.07RF8eMG077690>