From owner-svn-src-vendor@freebsd.org Thu Feb 22 01:04:59 2018 Return-Path: Delivered-To: svn-src-vendor@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7484FF13671; Thu, 22 Feb 2018 01:04:59 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BB7AA7DBA1; Thu, 22 Feb 2018 01:04:58 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w1M14v6w088615; Wed, 21 Feb 2018 17:04:57 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w1M14uHQ088614; Wed, 21 Feb 2018 17:04:56 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201802220104.w1M14uHQ088614@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r329770 - vendor-sys/illumos/dist/uts/common/fs/zfs/lua In-Reply-To: <201802220046.w1M0kOJw016757@repo.freebsd.org> To: Alexander Motin Date: Wed, 21 Feb 2018 17:04:56 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 01:04:59 -0000 [ Charset UTF-8 unsupported, converting... ] > Author: mav > Date: Thu Feb 22 00:46:24 2018 > New Revision: 329770 > URL: https://svnweb.freebsd.org/changeset/base/329770 > > Log: > 9035 zfs: this statement may fall through > > illumos/illumos-gate@46ac8fdfc5a1f9d8240c79a6ae5b2889cbe83553 > > Reviewed by: Yuri Pankov > Reviewed by: Andy Fiddaman > Reviewed by: Matthew Ahrens > Approved by: Dan McDonald > Author: Toomas Soome > > Modified: > vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c > vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c > vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c > vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c > > Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c > ============================================================================== > --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb 22 00:42:12 2018 (r329769) > +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb 22 00:46:24 2018 (r329770) > @@ -677,7 +677,7 @@ static void freeobj (lua_State *L, GCObject *o) { > case LUA_TUSERDATA: luaM_freemem(L, o, sizeudata(gco2u(o))); break; > case LUA_TSHRSTR: > G(L)->strt.nuse--; > - /* go through */ > + /* FALLTHROUGH */ > case LUA_TLNGSTR: { > luaM_freemem(L, o, sizestring(gco2ts(o))); > break; > > Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c > ============================================================================== > --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb 22 00:42:12 2018 (r329769) > +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb 22 00:46:24 2018 (r329770) > @@ -475,6 +475,7 @@ static int llex (LexState *ls, SemInfo *seminfo) { > else if (!lisdigit(ls->current)) return '.'; > /* else go through */ ^^^^^^^^^^^^^^^^^^^^^^^ Wasnt this already marked, perhaps in the wrong place with the wrong string? > } > + /* FALLTHROUGH */ > case '0': case '1': case '2': case '3': case '4': > case '5': case '6': case '7': case '8': case '9': { > read_numeral(ls, seminfo); > > Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c > ============================================================================== > --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c Thu Feb 22 00:42:12 2018 (r329769) > +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c Thu Feb 22 00:46:24 2018 (r329770) > @@ -514,7 +514,7 @@ static const char *match (MatchState *ms, const char * > } > case '+': /* 1 or more repetitions */ > s++; /* 1 match already done */ > - /* go through */ > + /* FALLTHROUGH */ > case '*': /* 0 or more repetitions */ > s = max_expand(ms, s, p, ep); > break; > > Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c > ============================================================================== > --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c Thu Feb 22 00:42:12 2018 (r329769) > +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c Thu Feb 22 00:46:24 2018 (r329770) > @@ -490,6 +490,7 @@ const TValue *luaH_get (Table *t, const TValue *key) { > return luaH_getint(t, k); /* use specialized version */ > /* else go through */ And again? > } > + /* FALLTHROUGH */ > default: { > Node *n = mainposition(t, key); > do { /* check whether `key' is somewhere in the chain */ -- Rod Grimes rgrimes@freebsd.org