Date: Mon, 06 Feb 2012 04:08:31 +0100 From: Dirk Engling <erdgeist@erdgeist.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: freebsd-rc@FreeBSD.org Subject: Re: Proposal ipv6_addrs_common Message-ID: <4F2F442F.3030509@erdgeist.org> In-Reply-To: <20120206.114622.2214566196455293098.hrs@allbsd.org> References: <4F2F209F.90309@erdgeist.org> <20120206.101800.1389796154758679137.hrs@allbsd.org> <4F2F3459.3090401@erdgeist.org> <20120206.114622.2214566196455293098.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06.02.12 03:46, Hiroki Sato wrote:
> ifconfig_tap0_aliases=" inet6 2001:db8:8888:2::1/64 inet6
> 2001:db8:9990-9999:3::1/64 inet 10.8.1.1/24 inet 10.8.0.1-10/24 "
Why on earth didn't you come forward with that earlier? Would've saved
me a lot of trouble. ;)
The bugs in /etc/network.subr, function ifalias_up I would like to see
fixed, anyway:
_ret=`ifalias_ipv4_up "$1"`
just does not work the way you imagined it. The return code is not
passed when using _ret=`` but the command substituted by it's output
on stdout, it should read:
ifalias_ipv4_up ${_if} && _ret=0
as shown in my patch.
> In my patch IPv6-mapped IPv4 address is not supported, but your
> patch can be merged easily.
I like the idea of configuring a router or DNS server for several
subnets with one range as well, i.e. "inet 10.8.2-16.1/24", do you
think this makes sense?
> One thing in my mind is whether allowing a variable which contains
> multiple lines is reasonable or not.
I do not understand the problem there, does your code actually DEPEND
on new lines? If not, it's just a matter of taste how to arrange your
variables in your rc.conf, if it doesn't fit in 80 chars, you can
either overflow, add backslashes or use the style above. The rc's
author does not FORCE the user into one style, does he?
erdgeist
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
iEYEARECAAYFAk8vRC8ACgkQuN1wFypsMNN1IgCeOo5OleODoIY6gS9SMO5p5uw1
n7cAn1k4CAnlcbHBhF2hppN+SDew7483
=54g5
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F2F442F.3030509>