Date: Wed, 14 Aug 2019 16:35:06 -0600 From: Adam Weinberger <adamw@adamw.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r508922 - in head: databases/opendbviewer devel/cmake devel/cmake-doc devel/cmake-gui devel/cmake/files devel/kms-cmake-utils graphics/peruse/files misc/libemos misc/libemos/files Message-ID: <CAP7rwchXaFapVoi2ieop=xXV%2BFr7GJ4JHVpJuB6%2BDt6ZXsBGQQ@mail.gmail.com> In-Reply-To: <5316998.XOh7uYVVfo@beastie.bionicmutton.org> References: <201908141418.x7EEIbcB050123@repo.freebsd.org> <CAMHz58QkXgvPc-eoi_-2zaK7ZWHZahGAtdYprTJP4yZbD=H7cQ@mail.gmail.com> <5316998.XOh7uYVVfo@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 14, 2019 at 3:28 PM Adriaan de Groot <adridg@freebsd.org> wrote: > > [[ Also BCC-ing some people who reported this separately. ]] > > On Wednesday, 14 August 2019 19:32:54 CEST Po-Chuan Hsieh wrote: > > > +%%DATADIR%%/Help/release/%%PYTHON_VER%%.rst > > > > This change is incorrect. > > And it breaks packaging for people not using Python 3.6 as default version. > > Your -- Po-Chuan Hsieh -- comment is entirely correct. That was a bad change > to the plist, and I'd like to thank adamw for stepping in and fixing it in > r508973. This is one of those unexpected replacements inserted into plists > when (re)generating them. I don't know how to express "not every 3.6 is a > PYTHON_VER" though to the tooling :( > > Something to keep checking in the future, I'll add it to the post-it. It's a catch-22. Some plists are way too difficult to update manually between releases, but the likelihood of error increases with size. Furthermore, you only get accurate and complete plists when all relevant options are enabled, which necessarily increases the size of the substitution set. I have a small script of sanity checks that I run before committing. One of them contains something like this (from memory; I don't have it in front of me): svn diff pkg-plist | grep '^\+.*/.*%%' The idea is to flag all the new lines that use plist substitutions anywhere except at the beginning. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwchXaFapVoi2ieop=xXV%2BFr7GJ4JHVpJuB6%2BDt6ZXsBGQQ>