From owner-svn-src-all@freebsd.org Thu Oct 20 11:50:41 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8901AC1A398; Thu, 20 Oct 2016 11:50:41 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0BDDCE6C; Thu, 20 Oct 2016 11:50:41 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-lf0-x242.google.com with SMTP id l131so487917lfl.0; Thu, 20 Oct 2016 04:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lDQWTFm3Y5Tom+5BuBtr+hxNda8klMYSN6WiSpzz1JQ=; b=TCZ2IlqzvwomzL4rAWB1EWZtmbX+GNYEW52c5nQRoHUXcYwESgOKvN9l77CpjW1uId 8iAoHpnx2389uXt+bWgAchx2XoUF9B2Jngt804km8KLHxTOsXyCQ2beGHsX9hFWxspaf bT+s16YhvQNvFdoguGLfGcvhdN+/Mv/N/lh8gyIP/IQs3vHx8X1aw+mqBL1V6KOduPYN HcsEDPjQfbmme3vyamXDVSt0AvtPVbuoT1zJF2YD9nbxHspXqqrZFkz3GQAVD2nx6c3h Jr7GVffBmH/XjTosYZKKIzOKxyRKyJq26rdPz7mLlHPg4SIJA5y/TWPzcCzVxBC4K2BX mC0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lDQWTFm3Y5Tom+5BuBtr+hxNda8klMYSN6WiSpzz1JQ=; b=jmY4MSSpF4t9SUVQJBZO57I0hjrzEbYiB3HROjklTVqjsRYLba2nOXsuPC53j8TzcY m70X+JsRmS2NNnCJweNqEFh1mqXUW9OUfcZGZ6aIrTvlqvmF31KPM+8BVQczSWnw/xdf 55oRWTUB5SfbTaWwvzENT9NeI4/SAI549ig5Ukxkx2yK/9UCGZIQ8OYIGt7148zXCR83 D/oh27qTJBGFfeVQwOT+MYkQaQ1jZrlywIIIW4b+JVUFIe1R7/ojHQ8Yr9JjEjBfDFqJ 80JEZSB3kjCba2j71Sja56Q9uPw2mrXwayl+V7wHAj6aJwbURdN4WqTbeN0gDS06SXxp z0ug== X-Gm-Message-State: AA6/9RlwWx9zrHTe5I2KhBlJ5q8wfLq0/YOoQlaKKpBzd13tBjn68ru2RSKu/+9rgn+w3w== X-Received: by 10.28.64.213 with SMTP id n204mr193277wma.64.1476964238952; Thu, 20 Oct 2016 04:50:38 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id wh3sm78172765wjb.49.2016.10.20.04.50.37 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 20 Oct 2016 04:50:38 -0700 (PDT) Date: Thu, 20 Oct 2016 13:50:35 +0200 From: Mateusz Guzik To: Gleb Smirnoff Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307650 - head/sys/kern Message-ID: <20161020115035.GA26990@dft-labs.eu> References: <201610191829.u9JITqhm081246@repo.freebsd.org> <20161019220942.GM27748@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161019220942.GM27748@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 11:50:41 -0000 On Wed, Oct 19, 2016 at 03:09:42PM -0700, Gleb Smirnoff wrote: > On Wed, Oct 19, 2016 at 06:29:52PM +0000, Mateusz Guzik wrote: > M> Author: mjg > M> Date: Wed Oct 19 18:29:52 2016 > M> New Revision: 307650 > M> URL: https://svnweb.freebsd.org/changeset/base/307650 > M> > M> Log: > M> cache: split negative entry LRU into multiple lists > M> > M> This splits the ncneg_mtx lock while preserving the hit ratio at least > M> during buildworld. > M> > M> Create N dedicated lists for new negative entries. > M> > M> Entries with at least one hit get promoted to the hot list, where they > M> get requeued every M hits. > M> > M> Shrinking demotes one hot entry and performs a round-robin shrinking of > M> regular lists. > M> > M> Reviewed by: kib > > This instapanics: > > panic: Assertion ncp->nc_flag & NCF_NEGATIVE failed at /usr/src/head/sys/kern/vfs_cache.c:815 > It definitely works for me and I don't see how the condition can fail. Given the 'instapanic' note, I assume you can easily reproduce. Is this a stock head kernel? Can you reproduce with; diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index a112808..a8bd5eb 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -812,6 +812,11 @@ cache_negative_zap_one(void) goto out; } + if (!(ncp->nc_flag & NCF_NEGATIVE)) { + panic("%s: ncp %p flag %x dvp %p vp %p\n", __func__, ncp, + ncp->nc_flag, ncp->nc_dvp, ncp->nc_vp); + } + MPASS(ncp->nc_flag & NCF_NEGATIVE); dvlp = VP2VNODELOCK(ncp->nc_dvp); blp = NCP2BUCKETLOCK(ncp); -- Mateusz Guzik