Date: Fri, 2 Mar 2018 18:57:51 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: yuri@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python <python@freebsd.org> Cc: "Tobias C. Berner" <tcberner@freebsd.org> Subject: Re: svn commit: r463374 - head/security/nyx Message-ID: <531069af-c0fc-1b2c-0c91-52cd73ba001e@FreeBSD.org> In-Reply-To: <6dd4b973-fbcb-8fa8-fb3e-1cece416898f@freebsd.org> References: <201803020651.w226ptn3091275@repo.freebsd.org> <6f698e1f-a5d5-2cd7-b2b7-c288a3c65bb6@FreeBSD.org> <6dd4b973-fbcb-8fa8-fb3e-1cece416898f@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/2/18 6:40 PM, Yuri wrote: > On 03/01/18 23:23, Kubilay Kocak wrote: >> This reason doesn't sound correct. Could you explain this further? > > > If the port can only be used as an app, as opposed to library, multiple > flavors aren't needed. All users care about is an executable. It doesn't > matter what python version is used. 1) Assuming what users care about is risky business. 2) The 'app vs library' distinction is not sound here. It wasn't sound for python package prefixing in the past either. 3) The change introduces and increases inconsistency among Python ports without an upside, without precluding downsides. 4) It feels similar to the PORTVERSION/DISTVERSION changes being introduced. Just because you can, doesn't mean you should. The bottom and most important line however, is that preventing Python port flavors from being produced precludes the user from choosing what version of the package they may want. lastly, the only reason the noflavors knob exists is because its not terribly pleasant as a developer to have features that cant be disabled, and because our framework can't imagine all the possible scenarios where a feature may cause issues. This isn't one of those scenarios. Could you please revert that specific change in both security/py-obfsproxy-tor and security/nyx? > > Yuri >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?531069af-c0fc-1b2c-0c91-52cd73ba001e>