From owner-svn-ports-head@freebsd.org Fri Mar 2 07:57:57 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A501F2CFFD; Fri, 2 Mar 2018 07:57:57 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com [IPv6:2607:f8b0:400e:c00::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D35EE72BCB; Fri, 2 Mar 2018 07:57:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x22a.google.com with SMTP id f80so3665444pfa.8; Thu, 01 Mar 2018 23:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ddW9UYeOAgPqhbmGGKVvAZljYZMpPyKE5QYt+zav5v4=; b=PkOUX/tBE6Vza+5j97qSVUMFUws+69jENXVcGgpLEZcIyG6guyPvJh5xC1Ltc8gxaB pMlBYSrqqKl9UEO7oG7Wy9WHLKi1DoYmkTHYgZLX4EbP7ur50BcsFqp17JHKHLW1yKUd H09Pzk0uMdKBcRS5FzUBb1PLpHABwZ5wijunf+uBFbfjQrsiMLzYWO0mGBZNn2CPWdZE qFhRrenxPOAG8VxkoHeFpwFRXeWs6M4XEcKPITp9xkrCxaxjPmTrNLY6FomBtJ1knUPG aw0nyaZTaakiVstg02WqZMcTjyvjWGEM903ZMMDLvdkY+CsNNcUU8Yg3HAQ1G+qN+fCq TF4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ddW9UYeOAgPqhbmGGKVvAZljYZMpPyKE5QYt+zav5v4=; b=mVAlLjWeEqr57PHjoNqGtgUCFSW6/gCZ2rg63GRGYR6x/XzFxRoKlCw6/acWagdUpL HSnFnIEbuKIEz4xC2j470khjDrg3y8/N5jNVfxf9NMn/qZwjBHgYWLg8SAgNZm6J+YOT 6qN7lq+p+Re2d9kfSrmPsyZI1uVjl3NUuDUrtKP3vQCygb3GE2VMwQQZYwQQFQInjaEh mF4woZMlJSGetdXhyyHmTKoYJs4KxGbdIeIl2Ev/XByiUdBfc3K8VwbczrUgORnOqjON VdQ00IybVK0/bThOMXo2gSQ4/hSro3HbvFjYk/V6I9fYPzJBP5FDzlh9LQ7GLg9m/w7r 4F6Q== X-Gm-Message-State: APf1xPDZN5hXre1HPI36Jr4y0oqDm//zn/Sit42I0DERJY+qFQlN7hIN ZyLSORWXlKgKhdyM9/jd9VY/p1uX X-Google-Smtp-Source: AG47ELv0SJSCW/BOMKE6kMN7GQoDUX0trKSAKdLhh1e1e1TeNh9hA0zMX0IQI2Pf9K16wkSl7vObwA== X-Received: by 10.99.122.12 with SMTP id v12mr3918996pgc.128.1519977475667; Thu, 01 Mar 2018 23:57:55 -0800 (PST) Received: from [192.168.1.100] (152.94.214.218.sta.wbroadband.net.au. [218.214.94.152]) by smtp.gmail.com with ESMTPSA id i11sm8846869pgq.34.2018.03.01.23.57.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Mar 2018 23:57:55 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r463374 - head/security/nyx To: yuri@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python Cc: "Tobias C. Berner" References: <201803020651.w226ptn3091275@repo.freebsd.org> <6f698e1f-a5d5-2cd7-b2b7-c288a3c65bb6@FreeBSD.org> <6dd4b973-fbcb-8fa8-fb3e-1cece416898f@freebsd.org> From: Kubilay Kocak Message-ID: <531069af-c0fc-1b2c-0c91-52cd73ba001e@FreeBSD.org> Date: Fri, 2 Mar 2018 18:57:51 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: <6dd4b973-fbcb-8fa8-fb3e-1cece416898f@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 07:57:57 -0000 On 3/2/18 6:40 PM, Yuri wrote: > On 03/01/18 23:23, Kubilay Kocak wrote: >> This reason doesn't sound correct. Could you explain this further? > > > If the port can only be used as an app, as opposed to library, multiple > flavors aren't needed. All users care about is an executable. It doesn't > matter what python version is used. 1) Assuming what users care about is risky business. 2) The 'app vs library' distinction is not sound here. It wasn't sound for python package prefixing in the past either. 3) The change introduces and increases inconsistency among Python ports without an upside, without precluding downsides. 4) It feels similar to the PORTVERSION/DISTVERSION changes being introduced. Just because you can, doesn't mean you should. The bottom and most important line however, is that preventing Python port flavors from being produced precludes the user from choosing what version of the package they may want. lastly, the only reason the noflavors knob exists is because its not terribly pleasant as a developer to have features that cant be disabled, and because our framework can't imagine all the possible scenarios where a feature may cause issues. This isn't one of those scenarios. Could you please revert that specific change in both security/py-obfsproxy-tor and security/nyx? > > Yuri >