From owner-svn-src-all@FreeBSD.ORG Sun Aug 31 15:24:38 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DF03FA38; Sun, 31 Aug 2014 15:24:38 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AF65E12C5; Sun, 31 Aug 2014 15:24:38 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1XO6zc-000Mlj-I1; Sun, 31 Aug 2014 15:24:36 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id s7VFOZ45001199; Sun, 31 Aug 2014 09:24:35 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18fxq4b5wUTHL28QmdioKwk X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan [172.22.42.240] claimed to be [172.22.42.240] Subject: Re: svn commit: r270862 - head/sys/arm/arm From: Ian Lepore To: "Bjoern A. Zeeb" In-Reply-To: References: <201408302221.s7UMLvMS003791@svn.freebsd.org> Content-Type: text/plain; charset="windows-1251" Date: Sun, 31 Aug 2014 09:24:35 -0600 Message-ID: <1409498675.1150.198.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by ilsoft.org id s7VFOZ45001199 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2014 15:24:39 -0000 On Sun, 2014-08-31 at 08:58 +0000, Bjoern A. Zeeb wrote: > On 30 Aug 2014, at 22:21 , Ian Lepore wrote: >=20 > > Author: ian > > Date: Sat Aug 30 22:21:57 2014 > > New Revision: 270862 > > URL: http://svnweb.freebsd.org/changeset/base/270862 > >=20 > > Log: > > Fix the handling of MMU type in the AP entry code. The ARM_MMU_V6/V= 7 > > symbols are always #defined to 0 or 1, so use #if SYM not #if define= d(SYM). > > Also, it helps if you include the header file that defines the symbo= ls. >=20 >=20 > I can only assume it=92s been due to this commit: >=20 > 22 warnings generated. > linking kernel.debug > locore.o: In function `mpentry': > (.text+0x1ec): undefined reference to `armv6_idcache_inv_all' > --- kernel.debug --- > *** [kernel.debug] Error code 1 >=20 > bmake: stopped in /storage/head/obj/arm.armv6/scratch/tmp/bz/head.svn/s= ys/ARMADAXP >=20 >=20 Yes, apparently this change exposed a long-standing bug in another header file. Fixed in r270878. -- Ian >=20 > >=20 > > Modified: > > head/sys/arm/arm/locore.S > >=20 > > Modified: head/sys/arm/arm/locore.S > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/arm/arm/locore.S Sat Aug 30 21:44:32 2014 (r270861) > > +++ head/sys/arm/arm/locore.S Sat Aug 30 22:21:57 2014 (r270862) > > @@ -37,6 +37,7 @@ > > #include > > #include > > #include > > +#include > > #include > >=20 > > __FBSDID("$FreeBSD$"); > > @@ -389,9 +390,9 @@ ASENTRY_NP(mpentry) > > nop > > CPWAIT(r0) > >=20 > > -#if defined(ARM_MMU_V6) > > +#if ARM_MMU_V6 > > bl armv6_idcache_inv_all /* Modifies r0 only */ > > -#elif defined(ARM_MMU_V7) > > +#elif ARM_MMU_V7 > > bl armv7_idcache_inv_all /* Modifies r0-r3, ip */ > > #endif > >=20 > >=20 >=20 > =97=20 > Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 198= 3 >=20 >=20