From owner-freebsd-ports@FreeBSD.ORG Tue Sep 13 17:35:36 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 79130106564A; Tue, 13 Sep 2011 17:35:36 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2443B8FC08; Tue, 13 Sep 2011 17:35:35 +0000 (UTC) Received: by ywp17 with SMTP id 17so806520ywp.13 for ; Tue, 13 Sep 2011 10:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=hOTBnCRRnyhCZOU8Xca/LJ9+z9MTY+k3If+736ZkYCU=; b=RIQZql5F6PEAdB5FbtyVMO1rwNw4iFa1o6Jx9Guc4P6Y7K2Wt8L5Gl8xM3eXv3YbUw C0V4aDtYiS9MCEdgRu/9Jd5B9xgUWQVRKg4ZNWeGFbGbU1sAy5SBogoXaZ02Xrc4xbBk sx0KhPVoTXswQEI8ngD0qDkTjIkI+KptdEXTA= Received: by 10.42.244.1 with SMTP id lo1mr1297938icb.419.1315935335135; Tue, 13 Sep 2011 10:35:35 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.61.148 with HTTP; Tue, 13 Sep 2011 10:35:05 -0700 (PDT) In-Reply-To: <86vcswjtod.fsf_-_@gmail.com> References: <20110913094514.071C8106573A@hub.freebsd.org> <20110913113322.GX79144@droso.net> <86vcswjtod.fsf_-_@gmail.com> From: Chris Rees Date: Tue, 13 Sep 2011 18:35:05 +0100 X-Google-Sender-Auth: MGC4cLJ2AIAcIMxxCEGo949tUAE Message-ID: To: h h Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Jason , freebsd-ports@freebsd.org Subject: Re: Is WRKDIR a user- or a port-defined variable? (Re: Screwy behavior in ports framework) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2011 17:35:36 -0000 On 13 September 2011 17:25, h h wrote: > (redirect from -current@ to -ports@) > > Erwin Lansing writes: > >> On Tue, Sep 13, 2011 at 09:45:05AM +0000, Thomas Mueller wrote: >>> >>> >>> PORTSDIR=3D/BETA1/usr/ports >>> PACKAGES=3D/usr/packages >>> WRKDIR=3Dworkb2 >>> # added by use.perl 2011-09-13 02:49:43 >>> PERL_VERSION=3D5.14.1 >>> >>> Maybe WRKDIR should have been ${MASTERDIR}/workb2 , or should it be ${.= CURDIR}/workb2 ? >> >> The latter. =A0Default for WRKDIR is ${WRKDIRPREFIX}${.CURDIR}/work, so >> you'll need to include ${.CURDIR} as well. > > If it's supported why WRKDIR assignments are not cleaned up? > > =A0databases/jasperserver/Makefile:WRKDIR=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0 = ${WRKDIRPREFIX}${.CURDIR}/work > =A0misc/py-xdelta3/Makefile:WRKDIR=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0${WRKDIR= PREFIX}${MASTERDIR}/work > =A0net/py-miniupnpc/Makefile:WRKDIR=3D =A0 =A0 =A0 =A0 =A0 =A0 ${WRKDIRPR= EFIX}${MASTERDIR}/work > > In fact, Porter's Handbook encourages its redefining unlike WRKDIRPREFIX > > =A0http://www.freebsd.org/doc/en/books/porters-handbook/porting-wrkdir.ht= ml > =A0http://www.freebsd.org/doc/en/books/porters-handbook/porting-wrkdirpre= fix.html > > Are you talking about new policy? Hm, a bit naughty. Perhaps something like: WRKDIR=3D ${WRKDIR:S/${.CURDIR}/${MASTERDIR}/} would be more appropriate? Jasperserver seems to do some pretty terrifying things though... Jason, could you explain why you're redefining WRKDIR to the default please= ?? Chris