From owner-freebsd-current@freebsd.org Tue Oct 15 02:26:27 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C94DA14BBF3 for ; Tue, 15 Oct 2019 02:26:27 +0000 (UTC) (envelope-from mueller6722@twc.com) Received: from dnvrco-cmomta02.email.rr.com (dnvrco-outbound-snat.email.rr.com [107.14.73.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46sfSK5G8Pz4TtD for ; Tue, 15 Oct 2019 02:26:25 +0000 (UTC) (envelope-from mueller6722@twc.com) Received: from localhost ([96.28.161.151]) by cmsmtp with ESMTP id KCXTiY3qbiYm2KCXWiVKPg; Tue, 15 Oct 2019 02:26:23 +0000 Date: Tue, 15 Oct 2019 02:25:15 +0000 From: "Thomas Mueller" To: freebsd-current@freebsd.org Subject: Re: sweeping change over all NIC drivers References: <20191014210736.GG4086@FreeBSD.org> X-CMAE-Envelope: MS4wfNe6GVnW5S3f6fiOGOq6KrD6k30FJ+OwvhdErkq21Xig7J0tVM2bG2pcufFYAbWWBeRK143rTMstYx5mOReHNREgazeI1kCgfwoeW1WoVbGG/4txqNoZ pTeNkqXheIE8skJ2EdACuYQM4lavQU7b+Ngikt2yq4DbneCO3ChqfNiw X-Rspamd-Queue-Id: 46sfSK5G8Pz4TtD X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mueller6722@twc.com designates 107.14.73.228 as permitted sender) smtp.mailfrom=mueller6722@twc.com X-Spamd-Result: default: False [0.21 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; RECEIVED_SPAMHAUS_PBL(0.00)[151.161.28.96.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:107.14.73.0/24]; FREEMAIL_FROM(0.00)[twc.com]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[twc.com]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.99)[-0.991,0]; MISSING_MID(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[228.73.14.107.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[twc.com]; ASN(0.00)[asn:7843, ipnet:107.14.73.0/24, country:US]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.00)[ip: (-3.60), ipnet: 107.14.73.0/24(-2.70), asn: 7843(-2.16), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2019 02:26:27 -0000 from Gleb Smirnoff: > I'd like to commit a sweeping change over all NIC drivers, > details can be found here: > https://reviews.freebsd.org/D21943 > The stack changes froim the review are already committed, > only a bunch of drivers are left. You can browse them as > individual commits here: > https://github.com/glebius/FreeBSD/commits/if_foreach_maddr > Although changes are close to trivial, there is always a place > for a mistake. So reviewing is appreciated. Testing is even > more appreciated. Here is list of drivers affected (65 total): (re and rtwn included but not rsu) I built FreeBSD 12-stable and current five months ago, and they have been sitting rather idle because of no internet access with current, and possible but very awkward with 12-stable. Only good thing I got was efibootmgr. I assume these changes are only for FreeBSD-current now and have to be tested and proven before committing to releng 12. But I am working on other things now on the computer and will not be able to get to FreeBSD-current immediately. Tom