Date: Thu, 2 Nov 2006 21:57:20 -0800 (PST) From: Nick Barkas <snb@threerings.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/105097: [maintainer update] [patch] Set IGNORE on sysutils/ipmi-kmod in 6-STABLE Message-ID: <20061103055720.C915A6682@smtp.earth.threerings.net> Resent-Message-ID: <200611030600.kA360bTk042144@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 105097 >Category: ports >Synopsis: [maintainer update] [patch] Set IGNORE on sysutils/ipmi-kmod in 6-STABLE >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Fri Nov 03 06:00:36 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Nick Barkas >Release: FreeBSD 5.4-RELEASE-p20 i386 >Organization: Three Rings Design >Environment: System: FreeBSD mail.earth.threerings.net 5.4-RELEASE-p20 FreeBSD 5.4-RELEASE-p20 #12: Thu Sep 28 14:09:16 PDT 2006 root@mail.earth.threerings.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: sysutils/ipmi-kmod should not be installed on systems where it is part of the base system. The port checks OSVERSION currently to determine whether the base system is a version it should work on. This doesn't work on 6-STABLE because OSVERSION is currently the same as 6.1, though -STABLE does have ipmi drivers in the base system (unlike 6.1). Instead of checking OSVERSION, this patch makes the port just check for the existence of ipmi driver code in the kernel sources, and if it's there IGNORE will be set. (The port already requires that kernel sources be installed). >How-To-Repeat: On a system running -STABLE, try installing sysutils/ipmi-kmod. Currently (for me) the port will not build properly, but it should not even try because of the presense of an ipmi driver in the base system. >Fix: Index: Makefile =================================================================== --- Makefile (revision 1173) +++ Makefile (working copy) @@ -7,6 +7,7 @@ PORTNAME= ipmi-kmod PORTVERSION= 20060926 +PORTREVISION= 1 CATEGORIES= sysutils MASTER_SITES= http://dpw.threerings.net/projects/ipmi-kmod/ @@ -37,8 +38,8 @@ IGNORE= requires kernel source to be installed .endif -.if ${OSVERSION} >= 601102 -IGNORE= already in the base system +.if exists(${SRC_BASE}/sys/dev/ipmi) +IGNORE= is already included in the base system .elif ${OSVERSION} < 503000 IGNORE= does not support FreeBSD before 5.3 .endif >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061103055720.C915A6682>