From owner-freebsd-bugs@FreeBSD.ORG Sun Jul 13 16:40:03 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 195091065670 for ; Sun, 13 Jul 2008 16:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E4C038FC14 for ; Sun, 13 Jul 2008 16:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6DGe2XK081537 for ; Sun, 13 Jul 2008 16:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6DGe2Vj081536; Sun, 13 Jul 2008 16:40:02 GMT (envelope-from gnats) Resent-Date: Sun, 13 Jul 2008 16:40:02 GMT Resent-Message-Id: <200807131640.m6DGe2Vj081536@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Iustin Pop Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E751106567A for ; Sun, 13 Jul 2008 16:34:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 767088FC13 for ; Sun, 13 Jul 2008 16:34:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6DGYbDu060067 for ; Sun, 13 Jul 2008 16:34:37 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m6DGYbXN060066; Sun, 13 Jul 2008 16:34:37 GMT (envelope-from nobody) Message-Id: <200807131634.m6DGYbXN060066@www.freebsd.org> Date: Sun, 13 Jul 2008 16:34:37 GMT From: Iustin Pop To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/125575: acl_valid() has wrong checks X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jul 2008 16:40:03 -0000 >Number: 125575 >Category: misc >Synopsis: acl_valid() has wrong checks >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jul 13 16:40:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Iustin Pop >Release: 7.0-release >Organization: >Environment: >Description: As described in http://lists.freebsd.org/pipermail/posix1e/2008-June/000491.html, acl_valid() checks that the ACL in question does not contain an ACL_USER with the same ID as the current user (and the same for ACL_GROUP). The check is not consisten with the kernel's validity check, and the POSIX.1e specification does not say such a check should be made. IMHO, the userland checks should be the consistent with the kernel checks. See also http://lists.freebsd.org/pipermail/posix1e/2008-July/000492.html Thank you! >How-To-Repeat: Create manually an ACL and try to add an ACL with the current user ID to it, via acl_from_text, acl_create_entry, acl_set_tag_type, acl_set_qualifier, and the acl_valid call on this ACL will fail. >Fix: >Release-Note: >Audit-Trail: >Unformatted: