From owner-cvs-src@FreeBSD.ORG Tue Sep 27 16:57:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D35116A41F; Tue, 27 Sep 2005 16:57:45 +0000 (GMT) (envelope-from rik@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67CA643D49; Tue, 27 Sep 2005 16:57:45 +0000 (GMT) (envelope-from rik@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8RGvjkM015327; Tue, 27 Sep 2005 16:57:45 GMT (envelope-from rik@repoman.freebsd.org) Received: (from rik@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8RGvj2n015326; Tue, 27 Sep 2005 16:57:45 GMT (envelope-from rik) Message-Id: <200509271657.j8RGvj2n015326@repoman.freebsd.org> From: Roman Kurakin Date: Tue, 27 Sep 2005 16:57:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/cp if_cp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2005 16:57:45 -0000 rik 2005-09-27 16:57:45 UTC FreeBSD src repository Modified files: sys/dev/cp if_cp.c Log: Restore if_cp.c 1.27 ---------------------------- revision 1.27 date: 2005/09/19 03:10:16; author: imp; state: Exp; lines: +3 -2 Make sure that we call if_free(ifp) after bus_teardown_intr. Since we could get an interrupt after we free the ifp, and the interrupt handler depended on the ifp being still alive, this could, in theory, cause a crash. Eliminate this possibility by moving the if_free to after the bus_teardown_intr() call. In fact, this change do nothing for this driver. It is protected from this by cp_destroy variable. This variable also protects driver from initiation of any activity from network stack with disabled intr handler with this change applied. Revision Changes Path 1.29 +3 -2 src/sys/dev/cp/if_cp.c