From owner-svn-ports-all@freebsd.org Sat Jun 30 00:49:20 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26052FDBF2B; Sat, 30 Jun 2018 00:49:20 +0000 (UTC) (envelope-from eugen@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CF8548342A; Sat, 30 Jun 2018 00:49:19 +0000 (UTC) (envelope-from eugen@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A51C8541; Sat, 30 Jun 2018 00:49:19 +0000 (UTC) (envelope-from eugen@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w5U0nJdJ034881; Sat, 30 Jun 2018 00:49:19 GMT (envelope-from eugen@FreeBSD.org) Received: (from eugen@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w5U0nJtf034880; Sat, 30 Jun 2018 00:49:19 GMT (envelope-from eugen@FreeBSD.org) Message-Id: <201806300049.w5U0nJtf034880@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: eugen set sender to eugen@FreeBSD.org using -f From: Eugene Grosbein Date: Sat, 30 Jun 2018 00:49:19 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r473592 - head/news/slrn X-SVN-Group: ports-head X-SVN-Commit-Author: eugen X-SVN-Commit-Paths: head/news/slrn X-SVN-Commit-Revision: 473592 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jun 2018 00:49:20 -0000 Author: eugen Date: Sat Jun 30 00:49:19 2018 New Revision: 473592 URL: https://svnweb.freebsd.org/changeset/ports/473592 Log: news/slrn: fix crash with SIGSERV in the iconv_convert_string() Back out r349278 that added --with-non-gnu-iconv trying to solve our early iconv() inconsistences that are not actual anymore as it now now correctly returns non-zero count of convertable symbols. This fixes unsigned underflow in the slrn code turning negative value to large positive leading to incorrect memory accesses later. PR: 228502 Approved by: johans (maintainer timeout, 1 month) Modified: head/news/slrn/Makefile Modified: head/news/slrn/Makefile ============================================================================== --- head/news/slrn/Makefile Fri Jun 29 22:45:57 2018 (r473591) +++ head/news/slrn/Makefile Sat Jun 30 00:49:19 2018 (r473592) @@ -3,6 +3,7 @@ PORTNAME= slrn PORTVERSION= 1.0.3a +PORTREVISION= 1 CATEGORIES= news ipv6 MASTER_SITES= http://www.jedsoft.org/releases/slrn/ @@ -19,7 +20,7 @@ USES= gmake iconv tar:bz2 GNU_CONFIGURE= yes CONFIGURE_ARGS+=--disable-inews --with-slrnpull \ - --with-non-gnu-iconv ${ICONV_CONFIGURE_ARG} + ${ICONV_CONFIGURE_ARG} ALL_TARGET= all WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION:C/[a-z]$//}