Date: Sat, 17 Dec 2016 17:38:01 +0100 From: Thomas Zander <riggs@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r428763 - in head/audio/fluidsynth: . files Message-ID: <CAFU734wwRb2iK11vUYmK=6qwg3qJBuwesJoMt-pbhE7BRqqRNQ@mail.gmail.com> In-Reply-To: <8e01a684-eef8-a3ab-1cea-757db5879feb@FreeBSD.org> References: <201612171341.uBHDfWIF098306@repo.freebsd.org> <8e01a684-eef8-a3ab-1cea-757db5879feb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 December 2016 at 14:50, Mathieu Arnold <mat@freebsd.org> wrote:
> Le 17/12/2016 =C3=A0 14:41, Thomas Zander a =C3=A9crit :
>> Modified: head/audio/fluidsynth/Makefile
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/audio/fluidsynth/Makefile Sat Dec 17 13:26:05 2016 (r=
428762)
>> +++ head/audio/fluidsynth/Makefile Sat Dec 17 13:41:32 2016 (r=
428763)
>> @@ -13,7 +13,7 @@ COMMENT=3D Real-time software synthesizer
>> LICENSE=3D LGPL20
>> LICENSE_FILE=3D ${WRKSRC}/COPYING
>>
>> -OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDIO =
SNDFILE
>> +OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDIO =
SNDFILE SNDIO
>> OPTIONS_DEFAULT=3D JACK
>
> This is missing a PORTREVISION bump.
Since when? The new SNDIO knob is disabled by default and the default
package remains unchanged.
>> +SNDIO_LIB_DEPENDS=3D libsndio.so:audio/sndio
>> +SNDIO_CMAKE_OFF=3D -Denable-sndio:BOOL=3DFALSE
>
> I guess this should probably be:
>
> SNDIO_CMAKE_BOOL=3D enable-sndio
At the moment, fluidsynth handles all CMAKE bool switches in the 'old'
fashion. We should update all of them, but I'd like to confirm that it
still builds.
Best regards
Riggs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU734wwRb2iK11vUYmK=6qwg3qJBuwesJoMt-pbhE7BRqqRNQ>