From owner-freebsd-current@FreeBSD.ORG Thu Aug 7 11:32:56 2014 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E1A2077E for ; Thu, 7 Aug 2014 11:32:55 +0000 (UTC) Received: from mail-wg0-x22b.google.com (mail-wg0-x22b.google.com [IPv6:2a00:1450:400c:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D6A72A1A for ; Thu, 7 Aug 2014 11:32:55 +0000 (UTC) Received: by mail-wg0-f43.google.com with SMTP id l18so3921101wgh.26 for ; Thu, 07 Aug 2014 04:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type; bh=fXtakixbLr55wBWU9qAR6MM0oWNwTHmAEi/aVtqYeh0=; b=nZdyR6nGhtqaxyzi5tDXw0PZwC2EXeM/HvMx3Rxedp2r1q2sOw3M8ju0s0VrXTtYwo 3Vkip6xK6FxW+2NS8XgNqUk0A6stfURk4YQojAhSp/aE6nXOHZAKKgZPsV2vvQII7PAc zCpE17lZt0kMyooRJ/eMAf/Gea7AoiR5cE6Mutai3aEXpWKyoQpB7JxtFmiXWohuKYmn ZCE10hIELo3TuXEw1bAaFhiebRbRPCoMsalWU4U0IPmbBKZoCQRnwxrZWifnlKzEcnIz rF2eZsVF146O3p0TKOB06SomFSRFH7txODPpRLg3lAyU3CdbzW9EAUAxKQfoeBlnvyoE rysQ== X-Received: by 10.195.11.234 with SMTP id el10mr24004789wjd.95.1407411173406; Thu, 07 Aug 2014 04:32:53 -0700 (PDT) Received: from [172.16.1.30] (39.Red-2-136-52.dynamicIP.rima-tde.net. [2.136.52.39]) by mx.google.com with ESMTPSA id lq15sm15893343wic.1.2014.08.07.04.32.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 07 Aug 2014 04:32:52 -0700 (PDT) Sender: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Message-ID: <53E363DD.4040105@FreeBSD.org> Date: Thu, 07 Aug 2014 13:32:45 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: David Wolfskill , =?ISO-8859-1?Q?Trond_Endres?= =?ISO-8859-1?Q?t=F8l?= , current@freebsd.org Subject: Re: panic: aatpic_assign_cpu: bad cookie [Was: Build machine OK; laptop panics @r269515] References: <20140804194759.GT1228@albert.catwhisker.org> <20140805142914.GJ1228@albert.catwhisker.org> <53E1450D.5090708@protected-networks.net> <53E14CD1.20308@protected-networks.net> <8B832384-C1CC-4622-BA67-7447ECE317C9@FreeBSD.org> <20140806210759.GM1228@albert.catwhisker.org> In-Reply-To: <20140806210759.GM1228@albert.catwhisker.org> Content-Type: multipart/mixed; boundary="------------010804040204010005020409" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Aug 2014 11:32:56 -0000 This is a multi-part message in MIME format. --------------010804040204010005020409 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit On 06/08/14 23:07, David Wolfskill wrote: > On Wed, Aug 06, 2014 at 10:48:32PM +0200, Trond Endrestøl wrote: >> ... >> Reverting r269510 did the trick, i.e.: >> >> cd /usr/src && svn up && svn diff -r 269510:269509 | patch >> >> My i386 head VM is running smoothly with r269641M, with M meaning only >> the above reversal. >> ... > > Works for me, as well -- thanks! > > FreeBSD 11.0-CURRENT #1333 r269622M/269622:1100028: Wed Aug 6 14:01:30 PDT 2014 > > (I'll be providing more details to royger@ et al. in a moment.) I think I've found the issue, but since I'm not able to reproduce it, could someone try the following patch? (without r269510 reverted). Thanks, Roger. --------------010804040204010005020409 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-atpic-make-sure-atpic_init-is-called-after-IO-APIC-i.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-atpic-make-sure-atpic_init-is-called-after-IO-APIC-i.pa"; filename*1="tch" >From 91264290520a6a6eee6cd35d05a65e2dd0e61dc8 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Thu, 7 Aug 2014 12:05:10 +0200 Subject: [PATCH] atpic: make sure atpic_init is called after IO APIC initialization After r269510 the IO APIC and ATPIC initialization is done at the same order, which means atpic_init can be called before the IO APIC has been initalized. In that case the ATPIC will take over the interrupt sources, preventing the IO APIC from registering them. Reported by: David Wolfskill Sponsored by: Citrix Systems R&D --- sys/x86/isa/atpic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sys/x86/isa/atpic.c b/sys/x86/isa/atpic.c index 6ce6d1a..e3fdb34 100644 --- a/sys/x86/isa/atpic.c +++ b/sys/x86/isa/atpic.c @@ -524,7 +524,7 @@ atpic_init(void *dummy __unused) intr_register_source(&ai->at_intsrc); } } -SYSINIT(atpic_init, SI_SUB_INTR, SI_ORDER_SECOND + 1, atpic_init, NULL); +SYSINIT(atpic_init, SI_SUB_INTR, SI_ORDER_FOURTH, atpic_init, NULL); void atpic_handle_intr(u_int vector, struct trapframe *frame) -- 1.7.7.5 (Apple Git-26) --------------010804040204010005020409--