From owner-freebsd-stable@FreeBSD.ORG  Wed Jan  4 19:58:08 2012
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 36066106566C;
	Wed,  4 Jan 2012 19:58:08 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 0B7138FC12;
	Wed,  4 Jan 2012 19:58:08 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id 9A54A46B09;
	Wed,  4 Jan 2012 14:58:07 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 25B87B90E;
	Wed,  4 Jan 2012 14:58:07 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: "Bjoern A. Zeeb" <bz@freebsd.org>
Date: Wed, 4 Jan 2012 14:40:35 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p8; KDE/4.5.5; amd64; ; )
References: <201201041620.q04GKupF086196@svn.freebsd.org>
	<201201041301.29611.jhb@freebsd.org>
	<CAE4F097-1672-4BD0-90BF-AC43834142A6@FreeBSD.org>
In-Reply-To: <CAE4F097-1672-4BD0-90BF-AC43834142A6@FreeBSD.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201201041440.35796.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Wed, 04 Jan 2012 14:58:07 -0500 (EST)
Cc: stable@freebsd.org
Subject: Re: svn commit: r229497 - in stable/8/sys: conf modules
	modules/ipfw netinet/ipfw
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2012 19:58:08 -0000

On Wednesday, January 04, 2012 2:09:44 pm Bjoern A. Zeeb wrote:
> On 4. Jan 2012, at 18:01 , John Baldwin wrote:
> 
> > On Wednesday, January 04, 2012 12:50:38 pm Jason Hellenthal wrote:
> >> 
> >> After this change I am recieving the attached error log.
> > 
> > My fault, looks like stable/8 doesn't have WITH_INET / WITHOUT_INET.
> > I'm doing tests on a fix now.
> 
> Alternatively I can MFC the knobs;  they are part of the other 50 possible
> MFCs in my mailbox to do;  I had just planned to wait on the entire 
stable/9/8/7
> sweep to go by first.
> 
> There was also a follow-up fix from me on this...

I have all your follow-ups AFAIK (I merged 3 changes).  Oddly, 
sys/modules/netgraph/ipfw/Makefile already references MK_INET_SUPPORT.  I 
guess no one has tried to build that outside of a kernel build on 8.

Bjoern has volunteered to MFC the knob to 8 to fix this.

-- 
John Baldwin