From owner-cvs-src-old@FreeBSD.ORG  Thu May 14 10:55:12 2009
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2E07106567F
	for <cvs-src-old@freebsd.org>; Thu, 14 May 2009 10:55:12 +0000 (UTC)
	(envelope-from kib@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B18F68FC17
	for <cvs-src-old@freebsd.org>; Thu, 14 May 2009 10:55:12 +0000 (UTC)
	(envelope-from kib@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n4EAtCZp088209
	for <cvs-src-old@freebsd.org>; Thu, 14 May 2009 10:55:12 GMT
	(envelope-from kib@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n4EAtClE088208
	for cvs-src-old@freebsd.org; Thu, 14 May 2009 10:55:12 GMT
	(envelope-from kib@repoman.freebsd.org)
Message-Id: <200905141055.n4EAtClE088208@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	kib@repoman.freebsd.org using -f
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Thu, 14 May 2009 10:54:57 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/kern kern_sysctl.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2009 10:55:13 -0000

kib         2009-05-14 10:54:57 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_sysctl.c 
  Log:
  SVN rev 192094 on 2009-05-14 10:54:57Z by kib
  
  Do not advance req->oldidx when sysctl_old_user returning an
  error due to copyout failure or short buffer.
  
  The later breaks the usermode iterators of the sysctl results that pack
  arbitrary number of variable-sized structures. Iterator expects that
  kernel filled exactly oldlen bytes, and tries to interpret half-filled
  or garbage structure at the end of the buffer. In particular,
  kinfo_getfile(3) segfaulted.
  
  Reported and tested by: pho
  MFC after:      3 weeks
  
  Revision  Changes    Path
  1.192     +5 -3      src/sys/kern/kern_sysctl.c