From owner-freebsd-current@FreeBSD.ORG  Sun Feb 17 03:25:29 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id CF638985
 for <freebsd-current@freebsd.org>; Sun, 17 Feb 2013 03:25:29 +0000 (UTC)
 (envelope-from davide.italiano@gmail.com)
Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com
 [209.85.128.172]) by mx1.freebsd.org (Postfix) with ESMTP id 828847E7
 for <freebsd-current@freebsd.org>; Sun, 17 Feb 2013 03:25:29 +0000 (UTC)
Received: by mail-ve0-f172.google.com with SMTP id cz11so4004437veb.31
 for <freebsd-current@freebsd.org>; Sat, 16 Feb 2013 19:25:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=vlgnOzpjecnx7DPfgjDHjeCDWm6JIJm+5WMl0Dqt63I=;
 b=n6bdw9H6fiw1cgtp1Hn8uFbak6z0kB1H0/QaUC9OOCflDKQ9hbgKbhpEBaQb7dHCXS
 y/wHY4uqDC5s3oS0fFVXAQQDt43pDto2DaFQtqvzP/5YbmWEwIsXgAF6+IIYrXl5mgUC
 by9KDxdJ3TKPzMWCd/uA6LpVU1yge7J0ZtgKnrRZ9m3V5UeVnslrFefObbAyMOtdzW6X
 gBr2Ghxr5UosxJnoGSjQBsSvfJcPL/DibdOSkJuf/TnNziQ5hDu2/doBO0wgL+wLT/Yh
 ZSvP+6SgPh0xYCixTvlMuMxyyKqXIGc/87udIhQIdZKOIZC3VjVop8BjGJbe1yYNCyTy
 2OAw==
MIME-Version: 1.0
X-Received: by 10.58.134.16 with SMTP id pg16mr10357573veb.12.1361071522528;
 Sat, 16 Feb 2013 19:25:22 -0800 (PST)
Sender: davide.italiano@gmail.com
Received: by 10.220.114.134 with HTTP; Sat, 16 Feb 2013 19:25:22 -0800 (PST)
In-Reply-To: <CALCpEUF0UwmEa4T3gyAH=YKDYczxZgUjtdjGZikNU4yTd=KKDg@mail.gmail.com>
References: <CALCpEUF0UwmEa4T3gyAH=YKDYczxZgUjtdjGZikNU4yTd=KKDg@mail.gmail.com>
Date: Sun, 17 Feb 2013 04:25:22 +0100
X-Google-Sender-Auth: LVzAXiihxKNF6hK_a_j1Pw7amxU
Message-ID: <CACYV=-EZ2Sr9STgCnUj+-xkWPKPV8Cz4-FhrVMY4v0VNCU_Jvg@mail.gmail.com>
Subject: Re: Running out of bits p_flag (sys/sys/proc.h)
From: Davide Italiano <davide@freebsd.org>
To: hiren panchasara <hiren.panchasara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Feb 2013 03:25:29 -0000

On Sun, Feb 17, 2013 at 2:58 AM, hiren panchasara
<hiren.panchasara@gmail.com> wrote:
> With revision=246484, it seems we have hit the limit.
> At $WORK we have one more flag and to accommodate that we need to bump this up.
>
> Can p_flag be bumped up to u_long?
>
> Index: proc.h
> ===================================================================
> --- proc.h      (revision 245937)
> +++ proc.h      (working copy)
> @@ -497,7 +497,7 @@
>          * The following don't make too much sense.
>          * See the td_ or ke_ versions of the same flags.
>          */
> -       int             p_flag;         /* (c) P_* flags. */
> +       u_long          p_flag;         /* (c) P_* flags. */
>         enum {
>                 PRS_NEW = 0,            /* In creation */
>                 PRS_NORMAL,             /* threads can be run. */
>
> Thanks,
> Hiren
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

I see at least two problems here:
- The change you propose may result in a KBI breakage.
- sizeof(unsigned long) == 4 on some archs, e.g. my i386 Atom, which
makes the change uneffective.

Thanks,

Davide