Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Jan 2018 12:34:39 +0000 (UTC)
From:      =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <dumbbell@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r460168 - head/graphics/darktable/files
Message-ID:  <201801281234.w0SCYdak081792@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dumbbell
Date: Sun Jan 28 12:34:39 2018
New Revision: 460168
URL: https://svnweb.freebsd.org/changeset/ports/460168

Log:
  graphics/darktable: Include `stddef.h` when testing zError() symbol
  
  The `CheckZlib.cmake` module uses `NULL` in the test source code to
  check for the `zError()` symbol. This fails to build on FreeBSD 10.3
  with the following error:
  
      CheckPrototypeDefinition.c:15:10: error: use of undeclared identifier 'NULL'
        return NULL;
               ^
  
  I don't know the root cause for this failure, but including `stddef.h`
  in this test source code fixes the problem.
  
  PR:		225501
  Reported by:	cpm@

Added:
  head/graphics/darktable/files/patch-src_external_rawspeed_cmake_Modules_CheckZLIB.cmake   (contents, props changed)

Added: head/graphics/darktable/files/patch-src_external_rawspeed_cmake_Modules_CheckZLIB.cmake
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/graphics/darktable/files/patch-src_external_rawspeed_cmake_Modules_CheckZLIB.cmake	Sun Jan 28 12:34:39 2018	(r460168)
@@ -0,0 +1,11 @@
+--- src/external/rawspeed/cmake/Modules/CheckZLIB.cmake.orig	2018-01-18 18:05:10 UTC
++++ src/external/rawspeed/cmake/Modules/CheckZLIB.cmake
+@@ -38,7 +38,7 @@ endif()
+ CHECK_PROTOTYPE_DEFINITION(zError
+  "const char* zError(int zErrorCode)"
+  "NULL"
+- "zlib.h"
++ "stddef.h;zlib.h"
+  HAVE_ZLIB_ZERROR_PROTOTYPE)
+ if(NOT HAVE_ZLIB_ZERROR_PROTOTYPE)
+   message(SEND_ERROR "Found unexpected prototype for zError() in <zlib.h>")



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801281234.w0SCYdak081792>